-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iheatmap!() #25
Conversation
Format code, mostly to standardize to 4-space indent as per Julia recommendations. Indent using spaces
Hi. Thanks this is very helpful. :) |
Currently the pooling functionality is not user-facing. It shouldn't be hard to make it available to the user, and I have a test implementation, but it needs some testing before I can PR it. Perhaps this weekend... |
HI again. You can see my post here from Mar 2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me.
My only nitpick is that your editing has now created a mix of 2-space indents and 4-space indents in the code, which is confusing. While I don't mind either option, given that the code base currently uses 2-space indents, would you mind switching to those for this project please? It'll also get rid of lots of unnecessary clutter in the diffs on this PR, making it easier to review for real code changes.
Okay, standardized to two-space indentation. |
LGTM, thanks! |
Add support for overlaying heatmaps on top of each other (adding to an existing axis).
I've also reorganised the code as discussed in #22 (comment)
Closes #24
May close #22
There are some issues - occasionally the image will tear when panning/zooming, but not sure what causes it. It may be a Makie issue.
Example using WGLMakie:
I have not tested with a disk-based array/matrix - hypothetically it should work.
Note: Every now and then, a warning will be raised.
The cause of this is already known MakieOrg/Makie.jl#2473 and is not caused by/related to the changes in this PR.