FIX Update to latest, including Swift Testing support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer possible to `@_spi(Experimental) import Testing`, so we can no longer ship a custom execution test trait. Instead of using such a trait to override a task local for the duration of a test, we can use a more general trait to store the information, and the assertion helpers can coalesce to the trait, instead.
* fix formatting of numbers to have stable snapshots as seen in pointfreeco#533 * fix to make tests compile pointfreeco#887 --------- Co-authored-by: stijn <[email protected]>
* fix missing inline snapshot testing * remove the need to import inline in not inline snapshot target --------- Co-authored-by: stijn <[email protected]>
* Fix assertSnapshot for Swift Testing tests. * wip * Update CI
|
It seems like the newest version of |
|
I think this is 1.17.6? The presentation on GitHub is a bit confusing to me and makes me thing the latest commit to this branch was 5 months ago. However, when I pull this down locally, my log looks like this: In case it's not obvious, I'm shooting to update to 1.17.6 |
lj-dickey
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest to get the Swift Testing changes.
Related: GUAC-5510