Add multi parent support to wallet #3228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arik/multi parent
raphjaph
commented
Aug 16, 2024
|
Ready for review |
casey
requested changes
Aug 17, 2024
There was a problem hiding this comment.
Mostly looks good to me, see comments! Do we need any tests which exercise other combinations of options? What happens when we etch a rune with multiple parents? What happens when we inscribe with multiple parents with different modes, like SharedOutput, SameSat, etc?
|
You may wanna rebase this before digging to deeply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3586 and #2494