Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C1-1153] Modified payload parsing of received message from kafka #787

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

tjcoyoca
Copy link
Collaborator

@tjcoyoca tjcoyoca commented Jul 2, 2024

Context

  • SQS and Redis expose the whole payload within the data/value, however, in kafka it stores it under value field/attribute making it hard to align the type for the expected task callback payload vs publish payload.

Changes

  • Store all kafka related informations on a metadata within the parsed data

This will avoid us calling steveo instead of the actual task: https://github.com/ordermentum/xero/compare/C1-1153-steveo-kafka-payload-update?expand=1

ticket: https://ordermentum.atlassian.net/browse/C1-1153

Screen Shot 2024-07-02 at 10 57 55 AM

Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 4a2a2a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
steveo Minor
@steveojs/datadog Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tjcoyoca tjcoyoca merged commit b8ce814 into main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants