Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched link/description in Readme.md #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Skytrias
Copy link
Collaborator

Just a thing I noticed when trying to open the MacOS link of adding path variables. Otherwise it linked to the windows example for both versions

Fix mismatched link/description
@martinfouilleul
Copy link
Collaborator

martinfouilleul commented Dec 21, 2024

good catch, but is there a reason for removing the markdown links formatting and replacing them with plain text?

@Skytrias
Copy link
Collaborator Author

good catch, but is there a reason for removing the markdown links formatting and replacing them with plain text?

just removed it since I saw it as a source of errors - since that is what was probably the case this time

@martinfouilleul
Copy link
Collaborator

martinfouilleul commented Dec 22, 2024

Yeah I agree it can be source of confusion since there's no check that the links corresponds to the text, but unfortunately some markdown readers won't automatically make raw links clickable... so I think it would be better to keep markdown formatting (ie just fix the url in the macos link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants