Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knot vector synthesis for approximate_curve and approximate_surface #121

Open
wants to merge 3 commits into
base: 5.x-dev
Choose a base branch
from

Conversation

GarthSnyder
Copy link

Fixes #119 and #120. Includes tests to verify that knot vectors are well-formed, that every knot span includes at least one new data point, and that knot vectors generated for reversed curves are the inverses of those generated in the opposite direction.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #121 (d1dcaea) into 5.x-dev (8ae8b12) will increase coverage by 0.48%.
The diff coverage is 100.00%.

❗ Current head d1dcaea differs from pull request most recent head 607e1b5. Consider uploading reports for the commit 607e1b5 to get more accurate results

@@             Coverage Diff             @@
##           5.x-dev     #121      +/-   ##
===========================================
+ Coverage    47.18%   47.67%   +0.48%     
===========================================
  Files           36       36              
  Lines         6739     6739              
  Branches      1663     1663              
===========================================
+ Hits          3180     3213      +33     
+ Misses        3270     3236      -34     
- Partials       289      290       +1     
Impacted Files Coverage Δ
geomdl/fitting.py 13.98% <100.00%> (+13.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant