Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add glossary #239

Merged
merged 5 commits into from
Aug 17, 2023
Merged

docs: add glossary #239

merged 5 commits into from
Aug 17, 2023

Conversation

deepeshaburse
Copy link
Contributor

This PR adds a Glossary section in the documentation.

@deepeshaburse
Copy link
Contributor Author

cc: @TerryHowe

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the rest later.

docs/glossary.mdx Outdated Show resolved Hide resolved
docs/glossary.mdx Outdated Show resolved Hide resolved
docs/glossary.mdx Outdated Show resolved Hide resolved
docs/glossary.mdx Outdated Show resolved Hide resolved
docs/glossary.mdx Show resolved Hide resolved
TerryHowe
TerryHowe previously approved these changes Aug 11, 2023
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sajayantony
sajayantony previously approved these changes Aug 11, 2023
@deepeshaburse
Copy link
Contributor Author

@TerryHowe and @sajayantony I added semantic line breaks for increasing readability.

sajayantony
sajayantony previously approved these changes Aug 11, 2023
docs/glossary.mdx Outdated Show resolved Hide resolved
@sajayantony sajayantony self-requested a review August 12, 2023 08:20
@sajayantony sajayantony dismissed their stale review August 12, 2023 08:21

OCI layouts hasn't yet made it in so merging this might be an issue.

Deepesha Burse and others added 5 commits August 17, 2023 23:10
Signed-off-by: Deepesha Burse <[email protected]>
Co-authored-by: Terry Howe <[email protected]>
Signed-off-by: Deepesha Burse <[email protected]>
Signed-off-by: Deepesha Burse <[email protected]>
Signed-off-by: Deepesha Burse <[email protected]>
Signed-off-by: Deepesha Burse <[email protected]>
@deepeshaburse
Copy link
Contributor Author

@TerryHowe @sajayantony the PR is ready to be merged if the content looks fine.

@sajayantony sajayantony merged commit 637a355 into oras-project:main Aug 17, 2023
6 checks passed
@deepeshaburse deepeshaburse deleted the glossary branch August 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants