[GR-48942] Run C extensions natively #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
changed the title
graalvmbot
force-pushed
the
bd/native-cexts
branch
5 times, most recently
from
3153a33 to
ec86536
Compare
graalvmbot
force-pushed
the
bd/native-cexts
branch
15 times, most recently
from
5847119 to
17b439b
Compare
graalvmbot
force-pushed
the
bd/native-cexts
branch
6 times, most recently
from
e8166b2 to
7dcc430
Compare
graalvmbot
force-pushed
the
bd/native-cexts
branch
from
7dcc430 to
5255978
Compare
* It is not accepted by gcc.
* It's much faster, 0.055s vs 0.677s and even 1.468s before --disable-gems
* Otherwise `system RbConfig::CONFIG['CC'], *args` fails.
* We could define ruby/spec-specific macros for this but it's easier to just reuse what's in ruby headers.
* So macOS actually looks in rpath instead of ignoring it...
* .../languages/ruby/lib/cext/include/truffleruby/truffleruby.h:48:59:
warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
[-Wgnu-zero-variadic-macro-arguments]
rb_exc_raise(rb_exc_new_str(EXCEPTION, rb_sprintf(FORMAT, ##__VA_ARGS__)))
^
* struct by value arguments are not well supported from NFI to Sulong, sometimes it works by chance due to how it is compiled to bitcode. * This is the only struct-by-value argument in the C API subset we implement.
* Remove entry about the LLVM toolchain since it is no longer relevant for users.
* Fixes the missing definition of NO_SANITIZE on linux-aarch64 with GCC 7.3.1. With the devtoolset it's GCC 10.2.1 on linux-aarch64.
graalvmbot
force-pushed
the
bd/native-cexts
branch
from
99ac23f to
7d4e433
Compare
graalvmbot
force-pushed
the
bd/native-cexts
branch
from
7d4e433 to
cb73607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.