Skip to content

Rework GitHub Release and Docker Actions #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FlyGoat
Copy link

@FlyGoat FlyGoat commented May 8, 2025

The universal goal is to make those actions available in forks, remove some cumbersome scripts and unnecessary steps, enable arm64 build and upload to ghcr.io as an alternative container registry.

Docker pushing/tagging policy is remaining unchanged.

For an example release run:
https://github.com/FlyGoat/opengrok/actions/runs/14887002399 (Triggered by release 99.1.3)

Which produced:
https://github.com/FlyGoat/opengrok/pkgs/container/opengrok
and
https://hub.docker.com/r/flygoat/opengrok

Also fixes #3948.

Thanks!

FlyGoat added 2 commits May 7, 2025 16:08
The universal goal is to make those actions available in forks,
remove some cumbersome scripts and unnecessary steps, enable
arm64 build and upload to ghcr.io as an alternative container
registry.

Signed-off-by: Jiaxun Yang <[email protected]>
The base image tomcat:10.1.40-jdk21 is actually based on Ubuntu
noble but we are still using Ubuntu jammy builder and perforce
apt source. Fix by making Ubuntu version explict everywhere.

helix-p4d is only available on 386/amd64, filter it out on other
architectures.

maintainer/source/description labels are only supposed to be set
on official builds, which is already done by docker/metadata-action
GitHub action, so remove them here.

Signed-off-by: Jiaxun Yang <[email protected]>
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 8, 2025
@FlyGoat
Copy link
Author

FlyGoat commented May 8, 2025

OCA already signed, seems pending approval.

@FlyGoat
Copy link
Author

FlyGoat commented May 8, 2025

Note that Docherhub's repository is set via DOCKER_SLUG repository variable. For this repo please set it to opengrok/docker before merge.

It should be set at: https://github.com/oracle/opengrok/settings/variables/actions

See also: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels May 13, 2025
@FlyGoat
Copy link
Author

FlyGoat commented May 15, 2025

Hi @vladak, This PR is ready.

I really wish to see an official arm64 docker release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create opengrok docker image for arm64
1 participant