refactor: use problog for suspicious combinations #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
SUSPICIOUS_COMBOS
dictionary to instead use aproblog
model. The purpose of this is to simplify the dictionary into logical statements, and allow for future development of probabilistic rules. This model transforms theHeuristicResult
types as follows:HeuristicResult.FAIL
results in<name> :- false.
HeuristicResult.PASS
results in<name> :- true.
HeuristicResult.SKIP
results in0.0::<name>
, which means any rules which require this heuristic do not trigger.To do:
Current issues with including
problog
that need to be resolved:problog
has no typing stubs. Currently it's just been ignored inpyproject.toml
.problog
currently causes the following warnings on tests: