fix: disable gpg signing for commit finder tests #939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (#932) New heuristic that checks for the presence of a wheel (.whl) file distributed with the pypi package, passing when a wheel file is present, and failing when it is absent. Signed-off-by: Carl Flottmann <[email protected]>
…a facts for pypi packages (#935) included as part of the wheel absence heuristic, it now returns instead of filenames links to the corresponding pypi inspector page as part of its information gathering.
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
938-gpg-commit-finder-test-hang
branch
from
6f2f536 to
e0f0499
Compare
|
See #940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the commit finder tests from hanging if the user's Git is configured to require gpg signing for tags, as noted by #938. This is achieved by overriding the config value for the temporary repository created by the test.
Closes #938