generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address comments from PR#873 #913
Merged
mabdollahpour-ol
merged 5 commits into
oracle:staging
from
mabdollahpour-ol:repository-verification
Nov 4, 2024
Merged
chore: address comments from PR#873 #913
mabdollahpour-ol
merged 5 commits into
oracle:staging
from
mabdollahpour-ol:repository-verification
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate API documents for modified and new code. - Make the repository verification check generic. - Fix repo verification fact parameter docs. Signed-off-by: Mohammad Abdollahpour <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Oct 30, 2024
…class Signed-off-by: Mohammad Abdollahpour <[email protected]>
behnazh-w
reviewed
Oct 30, 2024
…ationFacts Signed-off-by: Mohammad Abdollahpour <[email protected]>
Signed-off-by: Mohammad Abdollahpour <[email protected]>
behnazh-w
reviewed
Nov 3, 2024
Co-authored-by: Behnaz Hassanshahi <[email protected]> Signed-off-by: Mohammad Abdollahpour <[email protected]>
behnazh-w
approved these changes
Nov 4, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR aims to address the remaining comments from PR#873. - Generate API documents for modified and new code. - Make the repository verification check generic. - Fix repo verification fact parameter docs. Signed-off-by: Mohammad Abdollahpour <[email protected]> Co-authored-by: Behnaz Hassanshahi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the remaining comments from PR#873.