Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address comments from PR#873 #913

Merged

Conversation

mabdollahpour-ol
Copy link
Contributor

This PR aims to address the remaining comments from PR#873.

  • Generate API documents for modified and new code.
  • Make the repository verification check generic.
  • Fix repo verification fact parameter docs.

- Generate API documents for modified and new code.
- Make the repository verification check generic.
- Fix repo verification fact parameter docs.

Signed-off-by: Mohammad Abdollahpour <[email protected]>
@mabdollahpour-ol mabdollahpour-ol self-assigned this Oct 30, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 30, 2024
@mabdollahpour-ol mabdollahpour-ol marked this pull request as ready for review October 30, 2024 03:54
docs/source/index.rst Outdated Show resolved Hide resolved
Co-authored-by: Behnaz Hassanshahi <[email protected]>
Signed-off-by: Mohammad Abdollahpour <[email protected]>
@mabdollahpour-ol mabdollahpour-ol merged commit 7d3c63e into oracle:staging Nov 4, 2024
9 checks passed
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
This PR aims to address the remaining comments from PR#873.

- Generate API documents for modified and new code.
- Make the repository verification check generic.
- Fix repo verification fact parameter docs.

Signed-off-by: Mohammad Abdollahpour <[email protected]>
Co-authored-by: Behnaz Hassanshahi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants