chore: fix pylint message overlapping-except #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jenstroeger
force-pushed
the
lint/overlapping-except
branch
from
0049935 to
b979a8a
Compare
behnazh-w
approved these changes
Oct 2, 2024
Signed-off-by: Jens Troeger <[email protected]>
jenstroeger
force-pushed
the
lint/overlapping-except
branch
from
b979a8a to
b8d82c2
Compare
behnazh-w
approved these changes
Oct 2, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Jens Troeger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of issue #876 and addresses the
overlapping-exceptcheck messages. Because all errors were already handled in a singleexceptI left it that way — if errors need to be handled according to their error class hierarchy (e.g.shutil.Erroris a subclass ofOSError) then please let me know.I’ll add the appropriate configuration to pyproject.toml in a separate PR later.