-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command to run repo and commit finder without analysis #827
Conversation
I tried to run the
I believe we don't support Maven PURL without a version now - macaron/src/macaron/repo_finder/repo_finder_java.py Lines 53 to 56 in 44dbf0a
However, the debug message doesn't show up if I ran it without the verbose flag. I believe we should let the user of the |
I also think it's great to add an integration test case for the new command too (may be we can revisit this after we settle on how to return the results to the user). |
d431cab
to
bee7c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
…finding and commit finding for a PURL, or commit finding for a PURL and repo Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
…r cloning repos for tags; move report schema to separate file with test case; test both tag methods in integration case Signed-off-by: Ben Selwyn-Smith <[email protected]>
…n test for it Signed-off-by: Ben Selwyn-Smith <[email protected]>
… of integrat test Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
f0c6c5b
to
cab7bad
Compare
This PR adds a new command, find-source, that runs the commit finder and repo finder on a given PURL whilst skipping analysis. It also optionally accepts a repo path, in which case only the commit finder will be called. The results of the operation show up in the logs, and are written to a file in a JSON report format. Signed-off-by: Ben Selwyn-Smith <[email protected]>
This pull request adds a new command
find-source
that requires a PURL, and optionally accepts a repository path as input. If no repository path is provided, the command will call the Repo Finder and Commit Finder to find the repository and commit of the provided PURL. If a repository is provided as input, only the Commit Finder will be called.Closes #781