feat: use repository url provided as input for finding a commit #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Selwyn-Smith <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
benmss
changed the title
benmss
changed the title
nathanwn
reviewed
Feb 2, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
nathanwn
reviewed
Feb 6, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
|
This note in the documentation needs to be updated. Also, please add an example in the documentation to show how both a repo path and a PURL containing a version can be used at the same time. This PR could also be considered as a feature I think. |
benmss
changed the title
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
approved these changes
Feb 9, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR allows a user to provide to the command line: a repository URL with no digest alongside a PURL with a version. Signed-off-by: Ben Selwyn-Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases where the user has provided a PURL with a version but no repository can be found, this PR allows the analysis to succeed as long as the user provides a repository path as well. This differs from the current functionality where if both a PURL and repo are provided, a commit must be too.
An example of this new use case is added in the integration tests:
macaron analyze -purl pkg:maven/org.tinymediamanager/[email protected] -rp https://gitlab.com/tinyMediaManager/tinyMediaManagerWithout this new functionality, the above test would fail as the provided version cannot be found by the Repo Finder.
Closes #621