chore: display the repository URL status of dependencies in html report instead of the analysis status #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… instead of the analysis status
tromai
force-pushed
the
display-repository-status-of-dependencies-in-html-report
branch
from
c13360a to
5875036
Compare
behnazh-w
approved these changes
Nov 3, 2023
tromai
deleted the
display-repository-status-of-dependencies-in-html-report
branch
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…rt instead of the analysis status (#529) Signed-off-by: Trong Nhan Mai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull request fixes the issues in the HTML report of the main target where the dependencies are all displayed as
AVAILABLEeven though the repository URL is not available for them - see example below:with the content of
test_sbom.jsonas follows: test_sbom.jsonIn this example, Macaron cannot find the repository URL for the dependency component
javax.inject:javax.inject. However, Macaron still tries to run all checks on that component and produce an "empty" HTML report for it. This is part of the design implemented in this PR:Therefore, it's required to correctly display the repository URL status in the
statuscolumn (as shown in the example above). One of the reason why this is happening is because we are usingSCMStatusenum for two purposes:Implementation
This PR currently introduce a work-around for this issue. @behnazh-w Please let me know if it's preferred to use this work-around at the moment or implement a proper fix for it directly.