Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove CVE-2023-40590 and CVE-2023-41040 from the ignore list #459

Merged
merged 2 commits into from
Sep 13, 2023
Merged

chore(deps): remove CVE-2023-40590 and CVE-2023-41040 from the ignore list #459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1aa30
chore(deps): remove CVE-2023-40590 from the ignore list
behnazh-w Sep 2, 2023
11a1b64
chore(deps): remove CVE-2023-41040 from audit's ignore list
behnazh-w Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,12 @@ requirements.txt: pyproject.toml
# editable mode (like the one in development here) because they may not have
# a PyPI entry; also print out CVE description and potential fixes if audit
# found an issue.
# TODO: do not ignore CVE-2023-40590 once the patch is out.
# This CVE does not affect Macaron because we do not support Windows systems.
# See: https://github.com/gitpython-developers/GitPython/security/advisories/GHSA-wfm5-v35h-vwf4
# TODO: do not ignore CVE-2023-41040 once the patch is out.
# Macaron is not affected by this CVE because it does not call the problematic functions like `commit`
# and sanitizes arguments before calling GitPython APIs.
# See: https://osv.dev/vulnerability/GHSA-cwvm-v4w8-q58c
.PHONY: audit
audit:
if ! $$(python -c "import pip_audit" &> /dev/null); then \
echo "No package pip_audit installed, upgrade your environment!" && exit 1; \
fi;
python -m pip_audit --skip-editable --desc on --fix --dry-run --ignore-vuln CVE-2023-40590 --ignore-vuln CVE-2023-41040
python -m pip_audit --skip-editable --desc on --fix --dry-run

# Run some or all checks over the package code base.
.PHONY: check check-code check-bandit check-flake8 check-lint check-mypy check-go check-actionlint
Expand Down