[GR-73418] [GR-73419] Fix VMAccess and espresso exception issues.#13006
Closed
graalvmbot wants to merge 7 commits intomasterfrom
Closed
[GR-73418] [GR-73419] Fix VMAccess and espresso exception issues.#13006graalvmbot wants to merge 7 commits intomasterfrom
graalvmbot wants to merge 7 commits intomasterfrom
Conversation
Avoid inconsistent answers (and thus assertion errors) at the price of potentially having side effects.
Implement `has` & `getLanguageId`
Simpe move to agree with the order of other specialization methods.
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo in comment in
HotSpotTruffleRuntimeAvoid
NullPointerExceptionwhile printingPolyglotExceptionImprove
getException(Cause|Message)in espressoAvoid inconsistent answers (and thus assertion errors) at the price of potentially having side effects.
Improve Espresso
ForeignStackTraceElementObjectImplement
has&getLanguageId. This is necessary to get the<java>prefix after the recent changes for GR-35913.HostVMAccess.invoke: Avoid silently converting wrong argument types tonullEnsure the guest object of
InvocationExceptionis a properStaticObjectThis is best reviewed commit-by-commit.