Implement native object handles feature#12455
Open
asselyam wants to merge 2 commits intooracle:masterfrom
Open
Implement native object handles feature#12455asselyam wants to merge 2 commits intooracle:masterfrom
asselyam wants to merge 2 commits intooracle:masterfrom
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Author
|
@christianhaeubl Dear Dr. Häubl, i corrected the code, compile it and tested. If I understand right i create a new PR for every task or everzthing should be in one PR but in different branches? |
Accidentally the ObjectHandleImpl import was removed, I added it back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the implementation of the first steps and removed the duplicated code:
ObjectHandlesImpl is now only a storage class. Each instance contain either weak or strong handles.
JNIGlobalHandles uses 2 instances of ObjectHandlesImpl (one for strong handles, one for weak handles)
HandleWeakReference is removed