Extend wrapped JS function coverage in core runtime types #12263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame JSError to ThrownFromJavaScript - Introduced new methods to core JS runtime types to improve host interop - Renamed JSError to ThrownFromJavaScript for semantic clarity - Original name implied alignment with native JS Error, but the class represents any thrown JS object
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
axel22
reviewed
Oct 1, 2025
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Show resolved
Hide resolved
axel22
reviewed
Oct 1, 2025
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
Outdated
Show resolved
Hide resolved
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
patrick96
reviewed
Oct 7, 2025
...racle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/testdispatcher/JSAnnotationTests.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
Outdated
Show resolved
Hide resolved
web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSSymbolTest.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
Outdated
Show resolved
Hide resolved
web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSSymbolTest.java
Show resolved
Hide resolved
patrick96
reviewed
Oct 7, 2025
|
|
||
| @JS.Coerce | ||
| @JS(value = "return String.fromCharCode(...codeUnits);") | ||
| public static native JSString fromCharCode(int... codeUnits); |
There was a problem hiding this comment.
Could use use char... codeUnits instead here? The function only accepts numbers from 0 to 65535 anyway.
There was a problem hiding this comment.
Using int... matches JavaScript’s fromCharCode, which takes numbers, not characters. While char... would work for values ≤ 65535, it forces explicit casting for int values.
There was a problem hiding this comment.
In that case, we should have an overload that accepts char...
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSObject.java
Show resolved
Hide resolved
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSObject.java
Show resolved
Hide resolved
web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java
Outdated
Show resolved
Hide resolved
web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java
Outdated
Show resolved
Hide resolved
web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java
Outdated
Show resolved
Hide resolved
patrick96
reviewed
Oct 14, 2025
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
Outdated
Show resolved
Hide resolved
|
|
||
| @JS.Coerce | ||
| @JS(value = "return String.fromCharCode(...codeUnits);") | ||
| public static native JSString fromCharCode(int... codeUnits); |
There was a problem hiding this comment.
In that case, we should have an overload that accepts char...
sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
That's fine in that case. We can add them once we fix the underlying issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands the set of host-accessible wrappers for internal JavaScript functions across key runtime types:
JSObject,JSNumber,JSString,JSSymbol, andJSValue. These additions improve Java interop and simplify invocation of JavaScript behavior from host code.Additionally, the class
JSErrorhas been renamed toThrownFromJavaScriptto better reflect its actual role. The original name implied alignment with the native JavaScriptErrorobject, but the class more accurately represents any object thrown from JavaScript, regardless of its type.