Skip to content

[GR-65764] Add FFM method detection to the dynamic access analysis #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

[GR-65764] Add FFM method detection to the dynamic access analysis #11626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...vm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/DynamicAccessDetectionFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ public ConcurrentLinkedQueue<String> getMethodCallLocations(String methodName) {
"java.io.ObjectInputStream.readObject",
"java.io.ObjectStreamClass.lookup",
"java.lang.reflect.Array.newInstance",
"java.lang.ClassLoader.loadClass");
"java.lang.ClassLoader.loadClass",
"java.lang.foreign.Linker.nativeLinker");

public static final String GRAAL_SUBPATH = File.separator + "graal" + File.separator;
public static final String TRACK_ALL = "all";
Expand Down
20 changes: 18 additions & 2 deletions ...c/com.oracle.svm.hosted/src/com/oracle/svm/hosted/phases/DynamicAccessDetectionPhase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.io.ObjectStreamClass;
import java.lang.foreign.Arena;
import java.lang.foreign.FunctionDescriptor;
import java.lang.foreign.Linker;
import java.lang.foreign.MemorySegment;
import java.lang.invoke.ConstantBootstraps;
import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandleProxies;
Expand Down Expand Up @@ -75,7 +79,8 @@
public class DynamicAccessDetectionPhase extends BasePhase<CoreProviders> {
public enum DynamicAccessKind {
Reflection("reflection-calls.json"),
Resource("resource-calls.json");
Resource("resource-calls.json"),
Foreign("foreign-calls.json");

public final String fileName;

Expand All @@ -89,6 +94,7 @@ public record MethodInfo(DynamicAccessKind accessKind, String signature) {

private static final EconomicMap<Class<?>, Set<MethodSignature>> reflectionMethodSignatures = EconomicMap.create();
private static final EconomicMap<Class<?>, Set<MethodSignature>> resourceMethodSignatures = EconomicMap.create();
private static final EconomicMap<Class<?>, Set<MethodSignature>> foreignMethodSignatures = EconomicMap.create();

private final DynamicAccessDetectionFeature dynamicAccessDetectionFeature;

Expand Down Expand Up @@ -184,6 +190,11 @@ public record MethodInfo(DynamicAccessKind accessKind, String signature) {
resourceMethodSignatures.put(Class.class, Set.of(
new MethodSignature("getResource", String.class),
new MethodSignature("getResourceAsStream", String.class)));

foreignMethodSignatures.put(Linker.class, Set.of(
new MethodSignature("downcallHandle", MemorySegment.class, FunctionDescriptor.class, Linker.Option[].class),
new MethodSignature("downcallHandle", FunctionDescriptor.class, Linker.Option[].class),
new MethodSignature("upcallStub", MethodHandle.class, FunctionDescriptor.class, Arena.class, Linker.Option[].class)));
}

public DynamicAccessDetectionPhase() {
Expand Down Expand Up @@ -216,7 +227,8 @@ protected void run(StructuredGraph graph, CoreProviders context) {
private static MethodInfo getMethodInfo(ResolvedJavaMethod method) {
Class<?> declaringClass = OriginalClassProvider.getJavaClass(method.getDeclaringClass());
if (!reflectionMethodSignatures.containsKey(declaringClass) &&
!resourceMethodSignatures.containsKey(declaringClass)) {
!resourceMethodSignatures.containsKey(declaringClass) &&
!foreignMethodSignatures.containsKey(declaringClass)) {
return null;
}

Expand All @@ -236,6 +248,9 @@ private static MethodInfo getMethodInfo(ResolvedJavaMethod method) {
} else if (resourceMethodSignatures.containsKey(declaringClass) &&
resourceMethodSignatures.get(declaringClass).contains(methodSignature)) {
return new MethodInfo(DynamicAccessKind.Resource, declaringClass.getName() + "#" + methodSignature);
} else if (foreignMethodSignatures.containsKey(declaringClass) &&
foreignMethodSignatures.get(declaringClass).contains(methodSignature)) {
return new MethodInfo(DynamicAccessKind.Foreign, declaringClass.getName() + "#" + methodSignature);
}

return null;
Expand Down Expand Up @@ -288,6 +303,7 @@ private static NodeSourcePosition getRootSourcePosition(NodeSourcePosition nodeS
public static void clearMethodSignatures() {
reflectionMethodSignatures.clear();
resourceMethodSignatures.clear();
foreignMethodSignatures.clear();
}

private static class MethodSignature {
Expand Down
Loading