-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[GR-55581] Check layered image build option compatibility. #11207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
graalvmbot
wants to merge
21
commits into
master
Choose a base branch
from
paw/GR-55581
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+695
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6657b0c
to
be4e420
Compare
* Make -H:TempDirectory available as early as possible * Ensure layerDir respects -H:TempDirectory like all other builder generated temp files * Do not expose layer-snapshot.lsb and layer-snapshot-graphs.big to BuildArtifacts * Remove LAYER_SNAPSHOT and LAYER_SNAPSHOT_GRAPHS artifact types * Clean up LayerArchiveSupport class hierarchy * Clean up HostedImageLayerBuildingSupport
… element names lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first incarnation of checking layered builds to use mostly identical build arguments between parent layer and current layer build.
Using
-H:-LayerVerificationStrict
allows us to quickly find all offenders (seeWarning
messages):Note, how the found offenders can differentiate between changes where the position in the argument sequence matters (
-g
) and where it does not (--add-exports
).Without it, the first warning would already be an error that aborts the build:
The newly added annotation
com.oracle.svm.core.option.LayerVerification
allows us to selectively increase the amount of options where we want this checking to apply.