Skip to content

[GR-64701] Re-parse graphs in OptimizeLongJumpsTest. #11132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graalvmbot
Copy link
Collaborator

The OptimizeLongJumpsTest checks the number of jmp/jcc in raw machine code.
In rare circumstances, constants (e.g., displacements) in the code can look like opcodes for jmp/jcc which can transiently fail the test.
To avoid this, the code is emitted again in such cases (up to three times) as it is unlikely that such constants are present multiple times in a row.
However, emitting the code again also requires the graph to be parsed again.
Otherwise, the graph will already be in an unexpected state when doing the second code emit.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants