-
Notifications
You must be signed in to change notification settings - Fork 13
Removed use of Basic authentication for the sample app. #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ction of the end user handlers
oiramS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santiagoars Uppon further inspection of the changes, noticed that the discover functionality is now inaccessible if the user is not logged in, we may need to make those endpoints public as well and update the corresponding documentation section to avoid loss of service.
|
List of things to do before closing the ticket:
|
oiramS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement the requested changes and close the threads that will be implemented in a future PR. Once that is done re-request another review.
templates/ords-remix-jwt-sample/ords/migrateScripts/autoRESTEnableObjects.js
Show resolved
Hide resolved
oiramS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please:
- Update the whole export of the schema https://github.com/oracle/create-database-app/blob/main/templates/ords-remix-jwt-sample/Database/Modules/CONCERT_SAMPLE_APP.sql so the changes are also reflected there, I think I did this import using SQL Developer, let me double check.
- Bump the euser module version to v2 , since this is effectively a new version of the API
create-database-app/templates/ords-remix-jwt-sample/ords/modules/endUserModule.js
Line 28 in 597e88e
'euser/v1/',
templates/ords-remix-jwt-sample/Database/Modules/concert_app.euser.v1.sql
Show resolved
Hide resolved
templates/ords-remix-jwt-sample/ords/openAPI Catalog/concert_app.euser.v1.json
Outdated
Show resolved
Hide resolved
…variables and obsolete scopes
Just for reference, the unchecked items in this comment will be worked on a different PR. |
|
Assigning to @dbtools-antcampo so this can be merged. |


[PR] Removed use of Basic authentication for the sample app.