Skip to content

Conversation

@oiramS
Copy link
Contributor

@oiramS oiramS commented Nov 4, 2024

[PR] fix(deps): update ords-remix-jwt-sample dependencies

Description

Updates the following ords-remix-jwt-sample template dependencies:

Package From To
@remix-run/css-bundle 2.11.2 2.13.1
@remix-run/node 2.11.2 2.13.1
@remix-run/react 2.11.2 2.13.1
@remix-run/serve 2.11.2 2.13.1
@remix-run/dev 2.11.2 2.13.1
@types/react 18.3.0 18.3.12
eslint-plugin-jsx-a11y 6.9.0 6.10.2
postcss 8.4.38 8.4.47

Small note regarding the mui-dependencies group dependencies updates (#148):

It's not currently possible to update the @mui/material and @mui/icons-material dependencies from 6.0.2 to 6.1.6 since it seems to have introduced a breaking change in the way some of the components get imported (Currently investigating if this is a know issue) and as a result we would need to change how we import every component of the @mui/icons-material package. I do believe that we should not do this change at this stage given that this is a minor version and it could be changed again in the future.

SyntaxError: Named export 'AccountCircle' not found. The requested module '@mui/icons-material' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@mui/icons-material';

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:146:21)
    at ModuleJob.run (node:internal/modules/esm/module_job:229:5)
    at ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at run (/Users/luisdominguez/development/ords-concert-app/node_modules/@remix-run/serve/dist/cli.js:112:15)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Updated the dependencies listed above in the package.json file of the ords-remix-jwt-sample template.
  • Generated a new project from that template.
  • Executed the dev command of the project and confirmed that there were no import errors.
  • Did a full scan of the project and confirmed that everything worked as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] My changes generate no new warnings/errors
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] New and existing unit tests pass locally with my changes

@dbtools-antcampo dbtools-antcampo merged commit 597e88e into main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement. templates-ords-remix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants