Download SpringAI project as zip file #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include OpenAI API interface for chat completion
model checking for avoid hybrid deployement uses metadata.py catalog.
andytael
reviewed
Oct 25, 2024
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.3.0</version> |
andytael
reviewed
Oct 25, 2024
| <name>myspringai</name> | ||
| <description>Simple AI Application using OpenAPI Service</description> | ||
| <properties> | ||
| <java.version>17</java.version> |
andytael
reviewed
Oct 25, 2024
Comment on lines
+84
to
+87
| <dependency> | ||
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc11</artifactId> | ||
| <version>23.5.0.24.07</version> |
There was a problem hiding this comment.
This should be using the spring boot starter:
<dependency>
<groupId>com.oracle.database.spring</groupId>
<artifactId>oracle-spring-boot-starter-ucp</artifactId>
<version>24.3.0</version>
</dependency>There was a problem hiding this comment.
needs to be tested with 23ai Vector Search; will check.
andytael
reviewed
Oct 25, 2024
| @@ -0,0 +1,50 @@ | |||
| server: | |||
| servlet: | |||
| context-path: /v1 | |||
There was a problem hiding this comment.
If you use Java 21, then add:
threads:
virtual:
enabled: true
andytael
reviewed
Oct 25, 2024
Comment on lines
+231
to
+235
| spring: | ||
| datasource: | ||
| url: ${{spring.datasource.url}} | ||
| username: ${{spring.datasource.username}} | ||
| password: ${{spring.datasource.password}} |
There was a problem hiding this comment.
I think this code is the code that goes into application.yaml if so we should use a pooled connection:
datasource:
url: ${spring.datasource.url}
username: ${spring.datasource.username}
password: ${spring.datasource.password}
driver-class-name: oracle.jdbc.OracleDriver
type: oracle.ucp.jdbc.PoolDataSource
oracleucp:
connection-factory-class-name: oracle.jdbc.pool.OracleDataSource
connection-pool-name: UCPConnectionPool
initial-pool-size: 15
min-pool-size: 10
max-pool-size: 30
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringAI project download, supporting OpenAI/OLLAMA deployment.
Include OpenAI API REST interface for chat completion.
Not yet the full configuration available.