Updated README guide #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added timeout (30s), to give oracle time to return inference result. - Added note for PRIVATE_KEY exposure
changed timeout duration
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys! just make a suggestion readme file here:
some little things from my side:
the estimatedFee doesnt really need to be sent as a Number(estimatedFee).toString, so that's why i just removed those extra things (it worked well from my side)
it'd be nice if we dont need to manually estimateFee, and just call directly the calculateAIResult and it calculates the fee under the hood (making it optional) so this is 1 less function for the dev to interact with
i removed the dotenv part, i'd say this exra steps for a getting started guide are just adding more friction for a beginner getting to use the plugin, the idea is to get them as fast as possible to make that getAIResult call, but feel free to add it again if u want