Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

ci: update dependencies with UpdateCLI values #25

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

argoyle
Copy link
Member

@argoyle argoyle commented Jun 20, 2024

No description provided.

@argoyle argoyle force-pushed the add-updatecli-action branch 3 times, most recently from fe252ea to 86af7f4 Compare June 20, 2024 15:27
@argoyle argoyle requested a review from peter-svensson June 20, 2024 15:32
@argoyle
Copy link
Member Author

argoyle commented Jun 20, 2024

A first shot at this. We still need a way to run kubectl kustomize a couple of times though. There doesn't seem to be any support for that in updatecli yet. I created a feature request here: updatecli/updatecli#2257

peter-svensson
peter-svensson previously approved these changes Jun 24, 2024
Copy link
Member

@peter-svensson peter-svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@argoyle argoyle force-pushed the add-updatecli-action branch 18 times, most recently from 3e16ac0 to 522cc5f Compare June 26, 2024 14:03
@olblak
Copy link

olblak commented Jun 27, 2024

I hope you don't mind me making suggestion, I found this pullrequest while looking at the linked open issue

@peter-svensson
Copy link
Member

I hope you don't mind me making suggestion, I found this pullrequest while looking at the linked open issue

No worries at all, thanks for the feedback and insight 😊

@argoyle
Copy link
Member Author

argoyle commented Jun 27, 2024

Thanks for looking into this @olblak . In this case we actually want to create one PR with the changes from all targets. Is that possible? We have another PR in another repo (opzkit/terraform-aws-k8s-addons-external-secrets-operator#19) that is only updating one helm-chart which might be a better one to start with.

@olblak
Copy link

olblak commented Jun 27, 2024

In this case we actually want to create one PR with the changes from all targets
Yes it is and a common use case.

One manifest means one pipeline, within that pipeline all targets sharing the same scmid and actionid will target the same pullrequest.

Worth mentioning each target creates one commit and I would like to allow creating one commit for all targets in a near futur.

It is also possible for different manifests to update the same pullrequest as long as all manifests share the same pipelineid like in the policy ghcr.io/updatecli/policies/updatecli/githubaction:latest which you can visualize by running

updatecli manifest show ghcr.io/updatecli/policies/updatecli/githubaction:latest

@argoyle argoyle force-pushed the add-updatecli-action branch from 522cc5f to 8b918f9 Compare June 27, 2024 15:36
@argoyle argoyle force-pushed the add-updatecli-action branch 2 times, most recently from 8dc4abc to f391f1e Compare June 27, 2024 19:22
@argoyle argoyle requested a review from peter-svensson June 27, 2024 19:23
@argoyle argoyle force-pushed the add-updatecli-action branch 5 times, most recently from af1d83b to 09c6810 Compare June 28, 2024 07:48
@peter-svensson peter-svensson merged commit 6ea9dcd into main Jun 28, 2024
4 checks passed
@peter-svensson peter-svensson deleted the add-updatecli-action branch June 28, 2024 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants