Fix: Calc actual oSqthToMint instead of estimating #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| (uint256 crabCollateral, uint256 crabDebt) = | ||
| IZenBullStrategy(_zenBull).getCrabVaultDetails(); | ||
| // _ethIntoCrab.wmul(crabDebt).wdiv(crabCollateral.add(crabDebt.wmul(feeAdjustment))); |
There was a problem hiding this comment.
I kept it as a reference because the actual implementation is quite long with parentheses, so I'll just keep it
| _exactInFlashSwap( | ||
| usdc, | ||
| weth, | ||
| _params.wethUsdcPoolFee, | ||
| usdcToBorrow, | ||
| minWethForUsdcDebt, | ||
| wethToLend - (_params.depositsToProcess + wethFromAuction - ethIntoCrab), |
There was a problem hiding this comment.
Take minWethForUsdcDebt as input
There was a problem hiding this comment.
Will do this in separate PR
| vm.prank(owner); | ||
| vm.expectRevert(bytes("ZBN02")); | ||
| zenBullNetting.setOTCPriceTolerance(maxOtcPriceTolerance + 1); | ||
| zenBullNetting.setOTCPriceTolerance(3e17); |
There was a problem hiding this comment.
I made it private, to decrease contract size, so can't fetch it, trying to do with Vm though
| (, uint256 crabDebt) = IZenBullStrategy(ZEN_BULL).getCrabVaultDetails(); | ||
| uint256 oSqthAmount = crabAmount * crabDebt / crabTotalSupply; | ||
|
|
||
| (uint256 crabCollateral, uint256 crabDebt) = |
There was a problem hiding this comment.
Need the same in depositAuction integration tests (without angering the stack2deep gods)
alpinechicken
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: Calc actual oSqthToMint instead of estimating
Description
Fixes ENG-1508
Type of change