Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url accessible rules #2848

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Allow url accessible rules #2848

merged 7 commits into from
Jul 16, 2024

Conversation

niclim
Copy link
Contributor

@niclim niclim commented Jul 15, 2024

🍗 Description

What does this PR do? Anything folks should know?

Handles the different ways to specify your ruleset and allows it to be downloaded via URL (e.g. github URL)

  • from the optic.yml file -> extends key
    • in the optic.yml config: extends: https://gist.githubusercontent.com/niclim/9daff82cf3f68386fa24fec689796c18/raw/59f441e0bfe3911891e897fec6b8d515214a4047/gistfile1.txt
  • from the x-optic-standard key
    • e.g. in the api file x-optic-standard: https://gist.githubusercontent.com/niclim/9daff82cf3f68386fa24fec689796c18/raw/59f441e0bfe3911891e897fec6b8d515214a4047/gistfile1.txt

Also handles the hosting rule definitions locally

  • from the hosted custom rule -> can point to a GH url

📚 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

👹 QA

How can other humans verify that this PR is correct?

@niclim niclim marked this pull request as ready for review July 16, 2024 13:48
@niclim niclim requested a review from acunniffe as a code owner July 16, 2024 13:48
@niclim niclim added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 07cc93a Jul 16, 2024
3 checks passed
@niclim niclim deleted the allow-url-accessible-rules branch July 16, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants