Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setup CI tip #2325

Merged
merged 3 commits into from
Sep 20, 2023
Merged

add setup CI tip #2325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a7dab
add setup CI tip
Alexandre-Herve Sep 20, 2023
21fd95f
improve logging
Alexandre-Herve Sep 20, 2023
ad94cb6
Merge branch 'main' into add-ci-tips
Alexandre-Herve Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions projects/optic/src/commands/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,10 @@ export const getRunAction =
│ Local specs │
└─────────────────────────────────┘

[1]: Comparing your local specifications to their latest \`${cloudTag}\` version in Optic cloud.
(Optic compares against the target branch tag upon a PR/MR event, and the current branch tag otherwise)
[1]: Comparing your local specifications to their last uploaded Optic cloud version for tag \`${cloudTag}\`.
Optic compares local specs against the target branch upon PR/MR events, and the current branch upon push events or local runs.

[2]: Pushing local specs as latest versions for \`${currentBranchCloudTag}\` in Optic cloud.
(Updating the current branch tag)
[2]: Pushing local specs as latest versions in Optic cloud for tag \`${currentBranchCloudTag}\`, the current branch tag.

--------------------------------------------------------------------------------------------------`);
if (!commentToken && isPR) {
Expand Down Expand Up @@ -609,6 +608,13 @@ export const getRunAction =

await flushEvents();

if (!config.isInCi) {
logger.info('');
logger.info(
`🤖 Don't forget to add Optic to your CI flow: https://www.useoptic.com/docs/setup-ci`
);
}

if (exit1) {
logger.info(
'Exiting with code 1 as errors were found. Disable this behaviour with the `--severity none` option.'
Expand Down