Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc improvements #2322

Merged
merged 1 commit into from
Sep 20, 2023
Merged

misc improvements #2322

merged 1 commit into from
Sep 20, 2023

Conversation

Alexandre-Herve
Copy link
Contributor

@Alexandre-Herve Alexandre-Herve commented Sep 20, 2023

πŸ— Description

What does this PR do? Anything folks should know?

misc improvements and a bug fix

Optic matched 2 OpenAPI specification files:
todo-api.yaml, todo-api3.yaml.

βœ” Select the organization that your APIs belong to. Use an organization token to disambiguate in non interactive environments. β€Ί My organization

--------------------------------------------------------------------------------------------------

 β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
 β”‚  [1]      Optic Cloud      [2]  β”‚
 β””β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β–²β”€β”€β”€β”˜
     β”‚Compare            Updateβ”‚
 β”Œβ”€β”€β”€β–Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”
 β”‚           Local specs           β”‚
 β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜

 [1]: Comparing your local specifications to their latest `gitbranch:test` version in Optic cloud.
      (Optic compares against the target branch tag upon a PR/MR event, and the current branch tag otherwise)

 [2]: Pushing local specs as latest versions for `gitbranch:test` in Optic cloud.
      (Updating the current branch tag)

--------------------------------------------------------------------------------------------------

| TodoAPI (todo-api.yaml)
| β˜‘οΈ  No changes ❌ 8 design issues 
| View report: http://localhost:3001/organizations/c85230f7-4422-476a-8cbf-2a99ce0e5b8e/apis/e9SJK_mMiQ_eK2Cd00z6b/runs/GI9mHxOqQuoccqliq1WPD

| TodoAPI (todo-api3.yaml)
| β˜‘οΈ  No changes ❌ 6 design issues 
| View report: http://localhost:3001/organizations/c85230f7-4422-476a-8cbf-2a99ce0e5b8e/apis/K5DnCDr5ykIlZRG9TQe-G/runs/E6GpoeDo_YwK0JVh-09uG

Exiting with code 1 as errors were found. Disable this behaviour with the `--severity none` option.

πŸ“š References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

πŸ‘Ή QA

How can other humans verify that this PR is correct?

@Alexandre-Herve Alexandre-Herve added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit d25e041 Sep 20, 2023
1 check passed
@Alexandre-Herve Alexandre-Herve deleted the run-improvements branch September 20, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants