disable spinner

opticdev · Sep 26, 2023 · 35897bc · 35897bc
1 parent 091632f
commit 35897bc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/projects/optic/src/commands/capture/actions/captureRequests.ts b/projects/optic/src/commands/capture/actions/captureRequests.ts
@@ -289,7 +289,12 @@ function makeAllRequests(
 export async function captureRequestsFromProxy(
   config: OpticCliConfig,
   captureConfig: CaptureConfigData,
-  options: { proxyPort?: string; serverOverride?: string; serverUrl: string }
+  options: {
+    proxyPort?: string;
+    serverOverride?: string;
+    serverUrl: string;
+    disableSpinner?: boolean;
+  }
 ) {
   let app: ChildProcessWithoutNullStreams | undefined = undefined;
   let proxy: ProxyServer | undefined = undefined;
@@ -307,10 +312,12 @@ export async function captureRequestsFromProxy(
   const unsubscribeHook = exitHook(() => {
     cleanup();
   });
-  const spinner = getSpinner({
-    text: 'Generating traffic to send to server',
-    color: 'blue',
-  })?.start();
+  const spinner = options.disableSpinner
+    ? undefined
+    : getSpinner({
+        text: 'Generating traffic to send to server',
+        color: 'blue',
+      })?.start();
   let interactions: ProxyInteractions | null = null;
 
   const serverUrl = options.serverUrl;

diff --git a/projects/optic/src/commands/run.ts b/projects/optic/src/commands/run.ts
@@ -260,18 +260,17 @@ function report(report: SpecReport) {
   if (report.changelogLink) {
     logger.info(`| View report: ${report.changelogLink}`);
   }
+  logger.info('|');
   if (report.capture) {
-    const { bufferedOutput, coverage, unmatchedInteractions } = report.capture;
-    logger.info(
-      `| ${coverage}% API test coverage ${
-        unmatchedInteractions
-          ? `(${unmatchedInteractions} unmatched interactions)`
-          : ''
-      }`
-    );
+    const { bufferedOutput, coverage } = report.capture;
+    logger.info(`| API Test Coverage Report (${coverage}% coverage)`);
     bufferedOutput.forEach((output) => {
       logger.info(`| ` + output);
     });
+  } else {
+    logger.info(
+      `| Skipping API test verification (set up by running optic capture init ${report.path})`
+    );
   }
   logger.info('');
 }
@@ -535,6 +534,7 @@ export const getRunAction =
           captureConfig,
           {
             serverUrl: captureConfig.server.url,
+            disableSpinner: true,
           }
         );
         if (!harEntries) {