-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use infrahub image to run prefect server #5548
Conversation
This will avoid incompatibility issues between the Prefect client used by Infrahub and the Prefect server. This also avoid dirty workarounds in CI to make jobs work when we have a mismatch between the Prefect version in docker compose and the client used. Signed-off-by: Fatih Acar <[email protected]>
CodSpeed Performance ReportMerging #5548 will not alter performanceComparing Summary
|
Note: doing this would add a dependency on Prefect's Python version support, e.g. if Prefect does not support 3.14 we wouldn't be able to upgrade Infrahub to use 3.14, etc. |
I think this is already the case because we have it as a direct dependencies in python |
As a side note, Since we are also using |
Hm, we are using 3.13 in the SDK. I wonder if we should just get rid of pendulum. We talked about it in the past and the project seems fairly dead. |
I think we should get rid of |
We're thinking through this problem, too. We've identified https://github.com/ariebovenberg/whenever as a promising (albeit early) candidate. That said, since Prefect is >=3.9 we may just stoop to raw ZoneInfo (not sure we need a library for getting "now" in UTC). |
Thank you @aaazzam, |
This will avoid incompatibility issues between the Prefect client used by Infrahub and the Prefect server.
This also avoid dirty workarounds in CI to make jobs work when we have a mismatch between the Prefect version in docker compose and the client used.
Prefect's web UI is also working using this method.
Next step would be to have our own entrypoint to autoconfigure Prefect according to Infrahub's settings.