Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-pico-changes: expose and add method #142

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lnsun
Copy link
Member

@lnsun lnsun commented Jun 17, 2020

Added: getViewpointAdapter (moved to #147)
Exposed: isSubtype, fromTypeTree, computingAnnotatedTypeMirrorOfLHS

@lnsun
Copy link
Member Author

lnsun commented Jun 22, 2020

@xingweitian Thanks for the comments!

@lnsun
Copy link
Member Author

lnsun commented Jun 22, 2020

I noticed that SignednessTest also fails on opprop/master. Did anything from typetools changed?
Pulled latest updates form typetools.

@lnsun
Copy link
Member Author

lnsun commented Jun 24, 2020

Further split to mergable to typetools and not

@@ -173,7 +173,8 @@ public boolean isSubtype(
* @return returns true if {@code subtype} is a subtype of {@code supertype} in the qualifier
* hierarchy whose top is {@code top}
*/
protected boolean isSubtype(
@Override
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change

wmdietl added a commit to zcai1/checker-framework that referenced this pull request Jan 7, 2022
Co-authored-by: Suzanne Millstein <[email protected]>
Co-authored-by: Michael Ernst <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martin Kellogg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants