Handle deleted user in the assignee list #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
approved these changes
Feb 1, 2025
seanlip
reviewed
Feb 1, 2025
| @@ -199,6 +199,8 @@ def get_pull_request_dict_with_timestamp( | |||
| """ | |||
|
|
|||
| for assignee in pr_dict['assignees']: | |||
| if event['assignee'] is None or assignee is None: | |||
There was a problem hiding this comment.
@kevintab95 Could you please add a comment explaining the circumstances here before we merge this?
There was a problem hiding this comment.
Update -- I went ahead and made the change.
5 tasks
|
@kevintab95 I am curious to see the PR, can you share it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This run (https://github.com/oppia/oppia/actions/runs/13056262032) seems to have failed on a PR which had been reviewed by a now deleted user. This PR updates the code to handle this scenario.