-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #336: provided a clear description of where to add the repo name in the constants.js file. #340
Conversation
Provided a clear description of where to add the repo name in the constant.js file.
corrected constant.js to constants.js
Solved the changes raised by the maintainer
@seanlip I have updated the PR according to the norms. Please review again. Thank you |
1. Identify a target repository and install the bot by clicking the Install button on the settings page of your app, e.g., **`https://github.com/settings/apps/my-oppiabot-testing-app/installations`** | ||
2. Update the **`.env` file**: | ||
- Add your GitHub account name to `WHITELISTED_ACCOUNTS`. | ||
3. Add the repository name in the **`constants.js` file**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a blank line above "3." and above "2.", similar to how you have a space between sections 3. and 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlip will this work?
Added line above point 2 and 3 in the "Installing the bot on a repository" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
(And congrats on your first PR to Oppia!) |
Hi @Flying-Pegasus, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Thank you @seanlip for guiding me. Looking forward to solve more issues. Please merge the PR. |
Explanation
Updated the 'Installing the Bot on a Repository' section,
Added the bulletpoints to show step by step process.
The new lines I have added :
3. Added the repository name in the
constants.js
file:constants.js
file in the bot's source code.checksWhitelist
object.Example:
If your repository name is
my-repo
, thechecksWhitelist
object will look like this:4.Save the changes to
constants.js
.Checklist