Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #535: Material card corner white spacing[ON HOLD] #579

Closed
wants to merge 3 commits into from
Closed

Fix #535: Material card corner white spacing[ON HOLD] #579

wants to merge 3 commits into from

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Dec 31, 2019 •
edited
Loading

Explanation

This Pr fixes issue mentioned in #535. White spacing around the corners.

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/2cf61633-3197-4445-adb0-b58fbe418b11/TP-CL-Auto-Scroll-Button-

Screenshot

Screenshot_20191231-135145

rt4914
rt4914 suggested changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before passing any PR please self review first. The indentation is incorrect and remove the commented code too.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Dec 31, 2019
@veena14cs
Copy link
Contributor Author

Before passing any PR please self review first. The indentation is incorrect and remove the commented code too.

Missed to do it. Corrected indentation.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Dec 31, 2019
rt4914
rt4914 approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Dec 31, 2019
nikitamarysolomanpvt
nikitamarysolomanpvt reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small

PTAL on Kitkat it looks like this (API 19 4.4.2)

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Jan 2, 2020
@veena14cs
Copy link
Contributor Author

small

PTAL on Kitkat it looks like this (API 19 4.4.2)

Kitkat issue is getting tracked here in issue #530 and its related PR #537 and #536. This PR is fix for high-end device.

@nikitamarysolomanpvt
Copy link
Contributor

small PTAL on Kitkat it looks like this (API 19 4.4.2)

Kitkat issue is getting tracked here in issue #530 and its related PR #537 and #536. This PR is fix for high-end device.

This issue is already fixed in #537 & #536 considering all devices.... if this changes is not addressing all then, this major change in xml that need to be updated in several screen would be a trouble later on, as we are now focusing on kitkat also

@veena14cs veena14cs changed the title Fix #535: Material card corner white spacing Fix #535: Material card corner white spacing[ON HOLD] Jan 3, 2020
@veena14cs
Copy link
Contributor Author

This issue is already fixed in #537 & #536 considering all devices.... if this changes is not addressing all then, this major change in xml that need to be updated in several screen would be a trouble later on, as we are now focusing on kitkat also

I will keep this on hold. Will not merge this until #537 or #536 PR is fixed to avoid this kind of conflict.

@veena14cs
Copy link
Contributor Author

Closing this PR as it is fixed in #537 .

@veena14cs veena14cs closed this Jan 22, 2020
@veena14cs veena14cs deleted the material-card-corner-fix branch January 22, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt left review comments

@rt4914 rt4914 rt4914 approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @nikitamarysolomanpvt @rt4914