Fix part of #5485: Create means for verifying Fragment Arguments #5537
+3,769
−3,781
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import android.view.ViewParent | |
| import android.widget.FrameLayout | ||
| import androidx.appcompat.app.AppCompatActivity | ||
| import androidx.core.widget.NestedScrollView | ||
| import androidx.drawerlayout.widget.DrawerLayout | ||
| import androidx.test.core.app.ActivityScenario.launch | ||
| import androidx.test.core.app.ApplicationProvider | ||
| import androidx.test.espresso.Espresso.onView | ||
|
|
@@ -23,6 +24,7 @@ import androidx.test.espresso.matcher.ViewMatchers.isClickable | |
| import androidx.test.espresso.matcher.ViewMatchers.isRoot | ||
| import androidx.test.espresso.util.HumanReadables | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import com.google.common.truth.Truth.assertThat | ||
| import dagger.Component | ||
| import org.hamcrest.Matcher | ||
| import org.hamcrest.Matchers | ||
|
|
@@ -44,6 +46,7 @@ import org.oppia.android.app.application.ApplicationStartupListenerModule | |
| import org.oppia.android.app.application.testing.TestingBuildFlavorModule | ||
| import org.oppia.android.app.devoptions.DeveloperOptionsModule | ||
| import org.oppia.android.app.devoptions.DeveloperOptionsStarterModule | ||
| import org.oppia.android.app.model.AdministratorControlsFragmentArguments | ||
| import org.oppia.android.app.player.state.itemviewmodel.SplitScreenInteractionModule | ||
| import org.oppia.android.app.recyclerview.RecyclerViewMatcher.Companion.atPositionOnView | ||
| import org.oppia.android.app.recyclerview.RecyclerViewMatcher.Companion.scrollToPosition | ||
|
|
@@ -98,6 +101,7 @@ import org.oppia.android.testing.time.FakeOppiaClockModule | |
| import org.oppia.android.util.accessibility.AccessibilityTestModule | ||
| import org.oppia.android.util.caching.AssetModule | ||
| import org.oppia.android.util.caching.testing.CachingTestModule | ||
| import org.oppia.android.util.extensions.getProto | ||
| import org.oppia.android.util.gcsresource.GcsResourceModule | ||
| import org.oppia.android.util.locale.LocaleProdModule | ||
| import org.oppia.android.util.logging.EventLoggingConfigurationModule | ||
|
|
@@ -434,6 +438,36 @@ class AdministratorControlsFragmentTest { | |
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun testFragment_fragmentLoaded_verifyCorrectArgumentsPassed() { | ||
| launch<AdministratorControlsFragmentTestActivity>( | ||
| createAdministratorControlsFragmentTestActivityIntent( | ||
| profileId = internalProfileId | ||
| ) | ||
| ).use { scenario -> | ||
| testCoroutineDispatchers.runCurrent() | ||
| scenario.onActivity { activity -> | ||
|
|
||
| val administratorControlsFragment = activity.supportFragmentManager | ||
| .findFragmentById(R.id.administrator_controls_fragment_test_activity_fragment_container) | ||
| as AdministratorControlsFragment | ||
| val isMultipane = activity | ||
| .findViewById<DrawerLayout>(R.id.administrator_controls_activity_drawer_layout) != null | ||
|
|
||
| val arguments = checkNotNull(administratorControlsFragment.arguments) { | ||
| "Expected arguments to be passed to AdministratorControlsFragment" | ||
| } | ||
| val args = arguments.getProto( | ||
| ADMINISTRATOR_CONTROLS_FRAGMENT_ARGUMENTS_KEY, | ||
| AdministratorControlsFragmentArguments.getDefaultInstance() | ||
| ) | ||
| val receivedIsMultipane = args.isMultipane | ||
|
|
||
| assertThat(receivedIsMultipane).isEqualTo(isMultipane) | ||
|
There was a problem hiding this comment. Will 'isMultipane' always be true/false based on the configuration of the test? It would probably be more robust to set up the test such that we can always verify true/false as expected per the test setup (and add a second test for the opposite case so that both 'true' and 'false' are explicitly verified). There was a problem hiding this comment. @BenHenning , Please check, Could we do like this way? There was a problem hiding this comment. I don't think that will work--the activity lifecycle methods need to be handled by Android (and specifically Robolectric when running the tests locally). Normally multi-pane is automatically determined in production code by checking whether the current device is a tablet. We're able to configure tests to run with a tablet display environment (using per-test qualifiers). Would that work in this case? Here's one example of such a test configuration: |
||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun clickAutoUpdateTopicContainer() { | ||
| onView( | ||
| atPositionOnView( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than exposing internal state variables for test verification, is it possible to verify that the UI is in the correct state such that we can infer these? For example, could we check that the (expected) default story is currently expanded?