Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5533: Update workflows to use v4 of the upload-artifact #5534

Closed
wants to merge 5 commits into from

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Sep 11, 2024

Explanation

Fixes #5533

This PR includes

...v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions.

Passing checks with V4

[Stack trace]

Screenshot_20240912-125630

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@Rd4dev Rd4dev self-assigned this Sep 11, 2024
Copy link

Coverage Report

Results

Coverage Analysis: SKIP ⏭️

This PR did not introduce any changes to Kotlin source or test files.

To learn more, visit the Oppia Android Code Coverage wiki page

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Sep 11, 2024

@adhiamboperes, upgrading to v4 appears to resolve #5533. If it's fine, I can update this draft. (But it was pushed via GitHub web; I hope that won’t matter.) or if possible, could you open a PR for the same?

@Rd4dev Rd4dev changed the title Draft to replicate 5533 upload artifact v2 deprecated to upgrade to v4 Fix #5533: Update workflows to use v4 of the upload-artifact Sep 12, 2024
Copy link

Coverage Report

Results

Coverage Analysis: SKIP ⏭️

This PR did not introduce any changes to Kotlin source or test files.

To learn more, visit the Oppia Android Code Coverage wiki page

@Rd4dev Rd4dev marked this pull request as ready for review September 12, 2024 08:16
@Rd4dev Rd4dev requested a review from a team as a code owner September 12, 2024 08:16
@Rd4dev Rd4dev requested a review from BenHenning September 12, 2024 08:16
@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Sep 12, 2024

Closing this PR as the fix was included as a part of #5532

@Rd4dev Rd4dev closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CRITICAL]: Github Actions upload artifact deprecated
2 participants