Fix #5486 & part of #5343: Introducing new wiki page for code coverage usage and limitations

[Rd4dev]

Explanation

Fixes part of #5343
Fixes #5486

Project

[PR 2.6 of Project 4.1]

Changes Made

• This PR introduces 2 new wiki pages:
  • Oppia Android Code Coverage
  • Writing tests with Good Behavioural Coverage
• Fix to the comment upload feature permission issues with PRs created from the forked branches.
  • Split the code coverage workflow into 2
    1. Core code coverage workflow to handle
       • Collection of changed files
       • Bucket partitioning
       • Run coverage in matrices
    2. Comment upload workflow to handle
       • evaluation of reports
       • generation of md reports
       • uploading comments
       • Coverage Status Checks
         (as the later required pull_request_target)
• Fix to [BUG]: Code coverage workflow assumes a PR must be present #5486
  • The issue should have arisen as the pr got merged with the branch being deleted while the publish comment job still running, finding it hard to fetch the pr-issue number to publish a comment.
  • Now the Coverage Check Status was made to be dependent on the comment uploader ie. the final Coverage check job occurs only after the Evaluation and Comment jobs are done, so it will always have the pr reference)

  check_coverage_results:
    name: Check Code Coverage Results
    needs: [ evaluate-code-coverage-reports, comment_coverage_report ]

Reasons for splitting the code_coverage workflow

The single code_coverage workflow was split into

1. code_coverage (to run coverages)
2. coverage_report (to generate and publish reports)

Separating the comment upload job

• The primary reason is the need to have ability to upload comments from PRs opened from a fork branch.
  • pull_request_target: For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission, even when it is triggered from a fork.
  • Workflows triggered by pull_request_target events are run in the context of the base branch. Since the base branch is considered trusted, workflows triggered by these events will always run, regardless of approval settings. [GitHub Docs]

Separating the evaluation / generation of report job

• While initially it was split to help with 'skip files' - no files changed conditional check, with the introduction to 'SKIP' status check, it doesn't continue to serve the mentioned purpose.
• But if we still have it as one workflow then the flow will work as such:

Workflow 1: code_coverage

• compute changed files
• run coverage (needs compute changed files)
• evaluate / generate md
• code coverage check result

Workflow 2: coverage_report

• comment publication

If no .kt files changes are detected

• compute changed files
• skips run coverage
• skips evaluate / generate md
• pass code coverage check result

As the workflow was concluded as success, the 2nd workflow runs as,

• failed comment publication (as no report is generation due to skip)

But expectation is to still produce a pass check for the comment publication. (either to at least skip or upload a skip status as coverage comment report)

• With moving it to a separate workflow allows us to not make the evaluation / generation jobs rely on the Run coverage job making it independently behave once the code_coverage workflows are completed successfully.
• And it checks if pb files are generated and based on that it decides whether to generate PASS, FAIL or SKIP status checks.

Separating the coverage status check result job

There are 2 main reasons to moving it to new workflow. While it would still make sense to have it with the 1st workflow itself after Run coverage, the drawbacks are,

• If the check coverage status result was left with the 1st workflow, then when the Run coverage job completes in the 1st workflow the coverage status check result is set to true on success even before the sibling part of upload comment is done, making it an incomplete status result.
• [BUG]: Code coverage workflow assumes a PR must be present #5486 occurred as it lost its reference to the pr number, so making the coverage check status result dependent on (needs) the comment upload job should resolve this by only allowing the PR to be closed once the comment is uploaded.

Todo:

• [Done] Add a new wiki page for "Writing effective tests / Writing test with good behavioural coverage"

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 0 bytes (No change)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1 bytes (Added)

Method count: 259155 (old), 259155 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6806 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 378 (old), 378 (new), 0 (No change)
• Id: 1271 (old), 1271 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 378 (old), 378 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 848 (old), 848 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 0 bytes (No change)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 8 bytes (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 10 bytes (Added)

Method count: 115689 (old), 115689 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 18 bytes (Added)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 0 bytes (No change)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 9 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 bytes (Added)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 0 bytes (No change)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 1 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 0 bytes (No change)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1 bytes (Added)

Method count: 259155 (old), 259155 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6806 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 378 (old), 378 (new), 0 (No change)
• Id: 1271 (old), 1271 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 378 (old), 378 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 848 (old), 848 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 0 bytes (No change)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 8 bytes (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 10 bytes (Added)

Method count: 115689 (old), 115689 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 18 bytes (Added)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 0 bytes (No change)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 9 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 bytes (Added)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 0 bytes (No change)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 1 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

[Rd4dev]

@BenHenning, the current update includes the new wiki page titled "Oppia-Android Code Coverage." The page on "Writing Effective Tests / Writing Tests with Good Behavioral Coverage" has not been added yet. Could you PTAL at the first wiki page and provide feedback on the flow and structure?

[BenHenning]

Oops I think I accidentally submitted the review halfway through.

Thanks @Rd4dev! I think this is an excellent start. I have a bunch of comments, but most are just direct wording change suggestions to improve clarity. I don't have many content suggestions for the code coverage page since I think it's really well put together. I have a bunch more thoughts on the writing good tests page, and probably will have more after the next pass as well.

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 0 bytes (No change)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 21 bytes (Removed)

Method count: 259155 (old), 259155 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6806 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 378 (old), 378 (new), 0 (No change)
• Id: 1271 (old), 1271 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 378 (old), 378 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 848 (old), 848 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 6 bytes (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 8 bytes (Removed)

Method count: 115689 (old), 115689 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 29 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 6 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3 bytes (Added)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 19 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1 bytes (Added)

Method count: 259155 (old), 259155 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6806 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 378 (old), 378 (new), 0 (No change)
• Id: 1271 (old), 1271 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 378 (old), 378 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 848 (old), 848 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 0 bytes (No change)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 2 bytes (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 13 bytes (Removed)

Method count: 115689 (old), 115689 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 9 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 27 bytes (Removed)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 28 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 20 bytes (Removed)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 8 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 14 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

[Rd4dev]

Thank you so much, @BenHenning, for the detailed instructions that provided clear direction. I’ve revamped the 'Writing Tests with Good Behavioral Coverage' section and incorporated all the suggested changes to the Oppia Android code coverage page. I’ve addressed all the review comments; could you PTAL?

Additionally, the code coverage check required an additional skip files condition check to skip evaluations and upload of comments when no files are computed, so incorporated them to this PR as well.

[BenHenning]

Thanks @Rd4dev! I have only nits left in my comments code-wise.

Re: the 'working on develop' bit, what I'm actually referring to is how your previous PR broke the develop branch on Oppia Android. See this CI run: https://github.com/oppia/oppia-android/actions/runs/10375275721/job/28844581024 (accessible from the CI run on f9106d9).

Looking at your fork, it seems that merging in the example PR is still having some sort of issue (though now a different one): https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10493357497/job/29067124928. When a PR is merged, it kicks off a set of CI runs (including running tests and coverage for the whole codebase). We need to make sure that these CI workflows run and pass, and that for code coverage its "add comment to pull request" workflow is correctly ignored (since that's what's currently failing for Oppia Android).

Does this help clarify?

Re: the filed issues, just to confirm: are there any other JaCoCo gap issues that we need to keep track of? Or, put another way, will we as a team be able to start the process of moving all of our tests toward 100% code coverage once all of #5481, #5501, and #5503 are addressed? Or, is there anything else that will need to be done (that we know now or can at least anticipate) before that can happen?

If you have any follow-up discussions let's try to address them over chat, if possible, to speed up the last remnants of this PR (since it seems like it should be mergeable on the next review).

[Rd4dev]

@BenHenning, ahh actually thank you so much, for the reviews and also for pointing out to the exact failure check, only then I realized the workflow had a potential issue as it was including failure cases with the code coverage checks. :|

So, to fix that I made the coverage_report workflow to only allow success conclusions from the code_coverage workflow.

Reg. the confirmation on 'working on develop,' it has been observed that workflows using pull_request_target do not get triggered upon merging with the base branch. As a result, the coverage_report (workflow with comment upload job that uses pr number reference) workflow will never be triggered (since it's already based on the base branch), which means the issue seen in #5486 will no longer occur.

With both fixes applied, I ran two merge checks to confirm the 'working on develop',

• PR1: Checking if oppiabot, coverage reproter, repo messaging gets triggered on develop merge ci runs Rd4dev/Oppia-Android-Fork-from-Fork#16
• CI Check: https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10500935701

• PR2: [RunAllTests] Rd4dev/Oppia-Android-Fork-from-Fork#17
• CI Check: https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10503758101

Edit: Reassigning this issue for review as the remaining task is to confirm the functionality of pull_request_target. I will continue to explore other coverage gaps in the meantime.

Additional Context

To give a bit more context on why the previous Merge with the fork reported as fail is,

So, when I initially cloned the repo (not fork -- cloning it as a separate repo so I can't directly update it with upstream), I did not have the link to footnote wiki sections updated to the reports.
When I did add the sources for them later to CoverageReporter.kt, I did not care to update the tests over there as I thought it was just for testing purposes.

But recently while having it run on [RunAllTests], it triggered the CoverageReportTest and caused unit tests to fail.

and also in CI,
With auto enable rules I had just set the condition to check for "Check Code Coverage Result" so it had a potential drawback of even allowing merge with unit tests fail.

But it should have even failed for Check Code Coverage Result!!

And that is where I messed up keeping the allowed_conclusions in the coverage_report.yml.

Why was allowed_conclusions initially introduced?

So initially I did only have comment upload functionality to the 2nd split workflow, (having evaluation and code coverage check result in the 1st workflow) while doing that it was necessary to even allow failures (as min threshold would fail the check) to let it complete the uploading job. But then I moved the evaluation and check coverage result to the 2nd workflow too (I will add the reasons to the description for later reference), while still having the allowed_conclusions to allow failure, which is no longer needed as we now only do check the result in the final 2nd split workflow. Making it always a requirement to run coverages successfully (not based on min threshold) to get it through the 2nd workflow.

As earlier it was allowing even failure cases, when unit tests failed (CoverageReporterTest), the code coverage wait action too failed, skipping all coverage runs (no pb files uploaded), but as the 2nd workflow (that does the final check for coverage result) still triggered with failure allowed_action stack trace, and took the report as no files changed (as no pb files are generated since run coverages were skipped) and posted a skip coverage comment - Rd4dev/Oppia-Android-Fork-from-Fork#11 (comment) and made the check coverage result to pass and eventually merged it.

To fix this I had to remove allow_conclusions to only allow success cases:

-  allowed-conclusions: |
-              success
-              failure

To again test these:

1. I made a min threshold fail with auto enable merge on - Fail branch - test min threshold Rd4dev/Oppia-Android-Fork-from-Fork#14 (and it fails to merge as evaluation and coverage check result failed)
2. I made a test to intentionally fail with auto enable merge on - As unit tests will fail - auto merge should not be done Rd4dev/Oppia-Android-Fork-from-Fork#15 (and this fails to merge as unit test fails -> causing the check to wait for unit test fail -> causing the check to wait for run coverage to fail -> causing comment upload job to fail -> causing the check coverage result to eventually fail)

To confirm the develop works:

1. I set a passing coverage case with auto enable merge on - Removed 'add sign' Rd4dev/Oppia-Android-Fork-from-Fork#13 (it merged successfully)

Updating here as the coverage runs would still take some time to report,

It ran its set of merge develop ci run checks - https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10499496692, and it seems that only the workflows on pull_request gets triggered for these merge run -- I doubt if that is because the oppiabot and coverage_report are based on the base branch context and they are ignored for the base branch merge, since they are already based on them.

Also, for the above run, I have only triggered the unit tests and code coverage checks to speed up testing.

I ran another set of ci runs - [RunAllTests] with auto enable merge on while having 'unit test (gradle)', 'unit test(bazel)', coverage_report, oppiabot, code_coverage, repository_messaging workflows available and the same behavior can be seem as it ignored all the pull_request_target workflows for the merge run with base branch. workflow actions

As it can be seem from the actions above for the PR checks [RunAllTests] it does trigger

• Unit Tests (Gradle)
• Unit Tests (Bazel)
• Code Coverage
• Repository Messaging (set to true) - pull_request_target
• Oppiabot - pull_request_target
• Coverage Report - pull_request_target

But with the base branch merge, it only triggers

• Unit Tests (Gradle)
• Unit Tests (Bazel)
• Code Coverage

The repository_messaging failed stack trace, and I hope that has nothing to do with this, so I ignored it. (or does it?)

Also, I was unaware of the 2nd set of Merge base branch (develop) checks earlier, and with the behavior of the checks ignoring the pull_request_target triggers (if confirmed), we can expect the #5486 too to be resolved as they will never be triggered on the merge checks.

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 44 bytes (Added)

Method count: 259155 (old), 259155 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6806 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 378 (old), 378 (new), 0 (No change)
• Id: 1271 (old), 1271 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 378 (old), 378 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 848 (old), 848 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 31 bytes (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 48 bytes (Added)

Method count: 115689 (old), 115689 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 8 bytes (Removed)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Added)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 28 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 9 bytes (Removed)

Method count: 115695 (old), 115695 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5774 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 340 (old), 340 (new), 0 (No change)
• Id: 1217 (old), 1217 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 341 (old), 341 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 781 (old), 781 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 8 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 19 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

[Rd4dev]

@BenHenning, Reg.

are there any other JaCoCo gap issues that we need to keep track of?

I'm currently trying to generate HTML reports for a bunch of files to figure out if they miss reporting anything inspite of being hit, few findings are:

1. Termination statement:

Edit: Filed the issue - #5506

When the flow of execution is aborted by the termination statements, the line of code is not marked as covered. This can be seen with the use of exitProcess(1) in scripts,

RetrieveChangedFiles.kt

fun main(args: Array<String>) {
  if (args.size < 5) {
    println(
      "Usage: bazel run //scripts:retrieve_changed_files --" +
        " <encoded_proto_in_base64> <path_to_bucket_name_output_file>" +
        " <path_to_file_list_output_file> <path_to_test_target_list_output_file>"
    )
    println("Exiting...")
    exitProcess(1)
  }
  ...
}

The generated report shows coverage as:

and also this seems to be a known issue with jacoco:

Source code lines with exceptions show no coverage. Why?
JaCoCo determines code execution with so called probes. Probes are inserted into the control flow at certain positions. Code is considered as executed when a subsequent probe has been executed. In case of exceptions such a sequence of instructions is aborted somewhere in the middle and the corresponding lines of source code are not marked as covered.

I think this could be worth filing too, will go ahead and file this and update this comment with any other findings.

2. Assertions

While I believe this issue may be related to the same problem as described earlier #5506, I want to confirm this. In the DataProviderTestMonitor.kt file, we have the following lines:

fun <T> ensureDataProviderExecutes(dataProvider: DataProvider<T>) {
    // Waiting for a result is the same as ensuring the conditions are right for the provider to
    // execute (since it must return a result if it's executed, even if it's pending).
    val monitor = createMonitor(dataProvider)
    monitor.waitForNextResult().also {
        monitor.stopObservingDataProvider()
    }.also {
        // There must be an actual result for the provider to be successful.
        println("Asserting...")
        assertThat(it).isNotPending()
        println("After Asserting...")
    }
}

The generated HTML report:

The coverage report indicates that the lines with assertThat and println("After Asserting...") are not hit, which suggests they are not being executed during the test. Based on the test behavior, it seems that the assertion fails and throws an exception, interrupting the flow.

If the assertion fails and throws an AssertionError, this could indeed cause the subsequent lines to be skipped. However, I have not observed this behavior with other types of exceptions. I am investigating whether this issue is specifically related to AssertionError or if it affects other exceptions similarly.

And also, if this is considered to be filed, should it be added to the existing termination issue #5506 or as a separate issue?

(will add others as I find them)

[BenHenning]

Thanks @Rd4dev! Code looks good minus the final change to finalize the workflows to work correctly on both develop and forks (per our discussion today).

[Rd4dev]

@BenHenning, moved back the evaluation, check jobs, fixed a new issue with merge concurrent cancellations and added the proof of runs below, can you PTAL?

• I moved back the evaluation and check jobs back to the original workflow and just providing the expression of !cancelled was sufficient for the skip cases.

• But as expected I found another issue, and this is I guess something that exists in the develop ie. concurrency cancellations with the push: develop. So, the context is the ref with on: push, makes the grouping to 'develop', so if a subsequent merge to the develop was triggered it cancelled the previous merge jobs, I found it just today,

and to fix this I updated the concurrency grouping with pr number and a fall back run id value:

${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

Available references for develop and pr branches

Develop:

GitHub href:
GitHub ref: refs/heads/develop
GitHub workflow: Unit Tests (Robolectric - Bazel)
GitHub run-id: 10525996486
GitHub pr_number:

PR Number:

GitHub href: pr_number_group1
GitHub ref: refs/pull/31/merge
GitHub workflow: Unit Tests (Robolectric - Bazel)
GitHub run-id: 10526318852
GitHub pr_number: 31

• With the comment job isolated with just pull_request_target and making it unavailable for merge to base branch checks, [BUG]: Code coverage workflow assumes a PR must be present #5486 wouldn't occur again.

• One aspect discussed that was not implemented was allowing the evaluation job to pass regardless of the minimum threshold result and passing the value to the coverage check status result job to handle. I opted to explicitly fail the evaluation job to clearly indicate which stage of the workflow is failing. Since this doesn’t affect other parts of the process and with allowed_conclusions set to allow failure conclusions; the upload comments would still work., I believe we can keep it this way. Wanted to confirm if this is fine?

---

Proof of ci check runs for every mentioned case

FORK

• Pass report - PR | report
• Fail check should not auto merge - PR | report | stack trace
• Skip report - PR | report | stack trace

UPSTREAM

• Pass report - PR | report
• Fail check should not auto merge - PR | report | stack trace
• Skip report - PR | report | stack trace

Concurrency within PR

• Concurrency within PR cancels right: workflow actions | concurrency cancel trigger

Concurrency in develop merge on: push

• Concurrency with develop merge does not cancel other merge checks: workflow actions
  Merge checks from both PR 35 and PR 37 runs at the same time without cancelling after grouping concurrency with:

${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

---

Filing coverage gaps and related issues

• Filed the issue for - Limiting repeated code coverage and APK/AAB report generations in PRs - [BUG]: Limit repeated code coverage and APK/AAB report generations in PRs #5508

and reg. other coverage gaps, I haven't yet explored them completely...

[BenHenning]

Thanks @Rd4dev for the follow-up and extremely thorough verification analysis. This LGTM!

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!