Fix #4470, #4472, #4473 : Handle configuration change using onSavedInstance. #5478

Vishwajith-Shettigar · 2024-08-07T06:11:38Z

Explanation

Fixes #4470, Fixes #4472, Fixes #4473.

This PR enables the retention of input when the device configuration changes using onSavedInstance.

List of interactions covered in this PR:

Image Region selection interaction.
Drag and Drop interaction

| Drag and Drop |

draganddrop.mp4

| Image Region |

imageregion.mp4

Rest are covered in this PR #5458

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

…nges

Vishwajith-Shettigar · 2024-08-10T05:50:34Z

@adhiamboperes, could you please give this a green light for writing tests? Let me know if there are any concerns or suggestions for improvement.

github-actions · 2024-08-12T04:20:16Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4584 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 2834 bytes (Removed)

Method count: 259155 (old), 259252 (new), 97 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6788 (new), 18 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 954 (new), 13 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 14 others
Dimen: 1048 (old), 1043 (new), 5 (Removed):
- dimen/classrooms_card_collapsed_height (removed)
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- And 2 others
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4420 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 1985 bytes (Removed)
Method count: 259155 (old), 259252 (new), 97 (Added)
Resources: 6756 (old), 6738 (new), 18 (Removed)

Color: 967 (old), 954 (new), 13 (Removed)
Dimen: 1044 (old), 1039 (new), 5 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 14 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 100 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 5 bytes (Removed)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 4 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 140 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 6 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 100 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 8 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 3 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 6 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 39 KiB (Removed)

Method count: 115689 (old), 115164 (new), 525 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 38 KiB (Removed)
Method count: 115689 (old), 115164 (new), 525 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 8 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 7 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 12 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 KiB (Removed)

Method count: 115695 (old), 115160 (new), 535 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 36 KiB (Removed)
Method count: 115695 (old), 115160 (new), 535 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 7 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 9 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 11 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 44 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 33 KiB (Removed)

Method count: 115695 (old), 115160 (new), 535 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 37 KiB (Removed)
Method count: 115695 (old), 115160 (new), 535 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 9 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 6 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 13 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-08-12T10:15:38Z

@Vishwajith-Shettigar, I think it's good to go. We have already established the prefered solution, so feel free to complete the PR.

Vishwajith-Shettigar · 2024-08-12T11:06:38Z

@adhiamboperes, In image region selection interaction, when we select any default region in portrait mode and store coordinates in saved instances, and then rotate the device (landscape), we can't actually show the exact point of the default region selection mark, because the view size would be different in portrait and landscape mode, leading to the selection mark going anywhere. For more context i have attached screen recording.

WhatsApp.Video.2024-08-12.at.4.32.38.PM.mp4

A solution would be:
Either We can just ignore the default region selection retention since it is not very important.
Or we need to find a way to map portrait mode coordinates with the landscape view and landscape mode coordinates with portrait view.

github-actions · 2024-08-13T03:23:49Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4660 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 2621 bytes (Removed)

Method count: 259155 (old), 259252 (new), 97 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6806 (old), 6788 (new), 18 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 954 (new), 13 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 14 others
Dimen: 1048 (old), 1043 (new), 5 (Removed):
- dimen/classrooms_card_collapsed_height (removed)
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- And 2 others
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4500 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 1762 bytes (Removed)
Method count: 259155 (old), 259252 (new), 97 (Added)
Resources: 6756 (old), 6738 (new), 18 (Removed)

Color: 967 (old), 954 (new), 13 (Removed)
Dimen: 1044 (old), 1039 (new), 5 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 14 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 100 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 5 bytes (Removed)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 4 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 140 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 6 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 100 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 8 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 3 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 6 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Removed)

Method count: 115689 (old), 115164 (new), 525 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 40 KiB (Removed)
Method count: 115689 (old), 115164 (new), 525 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 8 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 7 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 12 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 KiB (Removed)

Method count: 115695 (old), 115160 (new), 535 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 35 KiB (Removed)
Method count: 115695 (old), 115160 (new), 535 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 7 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 9 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 11 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 KiB (Removed)

Method count: 115695 (old), 115160 (new), 535 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5774 (old), 5758 (new), 16 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 806 (new), 14 (Removed):
- color/color_def_greenish_black_1 (removed)
- color/color_def_greenish_black_2 (removed)
- color/color_def_greenish_black_3 (removed)
- color/color_def_pale_green_1 (removed)
- color/color_def_pale_green_2 (removed)
- And 13 others
Dimen: 780 (old), 778 (new), 2 (Removed):
- dimen/classrooms_card_collapsed_padding_vertical (removed)
- dimen/classrooms_card_margin_end (removed)
- dimen/classrooms_card_margin_start (removed)
- dimen/classrooms_card_padding_horizontal (removed)
- dimen/classrooms_card_padding_vertical (removed)
- And 3 others
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 37 KiB (Removed)
Method count: 115695 (old), 115160 (new), 535 (Removed)
Resources: 5731 (old), 5715 (new), 16 (Removed)

Color: 820 (old), 806 (new), 14 (Removed)
Dimen: 778 (old), 776 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 9 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 12 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 6 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 13 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 7 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-08-16T13:28:24Z

@Vishwajith-Shettigar, it sounds like a lot of engineering effort to map image selection cordinates on config change, that seems a bit out of scope for this issue. Besides, I tried testing with other popular apps(google apps, social media apps) to see how they handle such scenarios, and I found that they prefer to lock orientation as a workaround. So in our case, it is safe to not save the selection.

Vishwajith-Shettigar · 2024-08-16T13:36:36Z

Thanks @adhiamboperes.

Vishwajith-Shettigar · 2024-08-21T13:56:38Z

@adhiamboperes, PTAL.

github-actions · 2024-08-24T17:27:56Z

Coverage Report

Results

Number of files assessed: 6
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
RegionClickEvent.kt app/src/main/java/org/oppia/android/app/utility/RegionClickEvent.kt	This file is exempted from having a test file; skipping coverage check.
ClickableAreasImage.kt app/src/main/java/org/oppia/android/app/utility/ClickableAreasImage.kt	This file is exempted from having a test file; skipping coverage check.
ImageRegionSelectionInteractionView.kt app/src/main/java/org/oppia/android/app/player/state/ImageRegionSelectionInteractionView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DragAndDropSortInteractionViewModel.kt app/src/main/java/org/oppia/android/app/player/state/itemviewmodel/DragAndDropSortInteractionViewModel.kt	This file is exempted from having a test file; skipping coverage check.
ImageRegionSelectionInteractionViewModel.kt app/src/main/java/org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt	This file is exempted from having a test file; skipping coverage check.
StateFragment.kt app/src/main/java/org/oppia/android/app/player/state/StateFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

LGTM, thanks @Vishwajith-Shettigar!

github-actions · 2024-08-26T11:46:53Z

Coverage Report

Results

Number of files assessed: 6
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
RegionClickEvent.kt app/src/main/java/org/oppia/android/app/utility/RegionClickEvent.kt	This file is exempted from having a test file; skipping coverage check.
ClickableAreasImage.kt app/src/main/java/org/oppia/android/app/utility/ClickableAreasImage.kt	This file is exempted from having a test file; skipping coverage check.
ImageRegionSelectionInteractionView.kt app/src/main/java/org/oppia/android/app/player/state/ImageRegionSelectionInteractionView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DragAndDropSortInteractionViewModel.kt app/src/main/java/org/oppia/android/app/player/state/itemviewmodel/DragAndDropSortInteractionViewModel.kt	This file is exempted from having a test file; skipping coverage check.
ImageRegionSelectionInteractionViewModel.kt app/src/main/java/org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt	This file is exempted from having a test file; skipping coverage check.
StateFragment.kt app/src/main/java/org/oppia/android/app/player/state/StateFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Vishwajith-Shettigar added 2 commits August 7, 2024 11:38

Drap and drop interaction retain input when devices configuration cha…

3274c45

…nges

klint

f73b5e7

adhiamboperes assigned Vishwajith-Shettigar Aug 7, 2024

Vishwajith-Shettigar added 8 commits August 9, 2024 09:06

retain input in image selection interaction

b42552a

klint

cebc439

Clean up

1e99c58

Added comments

01a426e

Clean up

07ff0ac

remove observer

bfaf1f2

remove observer

a9647ba

Added comment

7597c1d

Vishwajith-Shettigar assigned adhiamboperes and unassigned Vishwajith-Shettigar Aug 10, 2024

Vishwajith-Shettigar added 2 commits August 10, 2024 11:35

Modified comment

fe281dd

Reorganize code for clarity

f7b59b6

adhiamboperes assigned Vishwajith-Shettigar and unassigned adhiamboperes Aug 12, 2024

Vishwajith-Shettigar assigned adhiamboperes and unassigned Vishwajith-Shettigar Aug 12, 2024

Added test for drag and drop and image interaction inout

8420daa

Vishwajith-Shettigar changed the title ~~Fix part of #4470: : Handle configuration change using onSavedInstance.~~ Fix #4470: : Handle configuration change using onSavedInstance. Aug 13, 2024

Vishwajith-Shettigar changed the title ~~Fix #4470: : Handle configuration change using onSavedInstance.~~ Fix #4470, #4472, #4473 : Handle configuration change using onSavedInstance. Aug 13, 2024

Vishwajith-Shettigar mentioned this pull request Aug 13, 2024

Fix part of #4470, Fix #4471, Fix 4474: Handle configuration change using onSavedInstance. #5458

Merged

6 tasks

Vishwajith-Shettigar added 2 commits August 13, 2024 11:00

handle null using let

6e7aa3e

Fix test

c2b0e66

Vishwajith-Shettigar and others added 6 commits August 14, 2024 09:22

Merge branch 'develop' into retain-input

cb9e639

modified tests

73a4203

modified tests

f11ae72

modified tests

50f35db

Added test for drag and drop error message

654414d

klint

5220eb5

adhiamboperes assigned Vishwajith-Shettigar and unassigned adhiamboperes Aug 16, 2024

Vishwajith-Shettigar added 2 commits August 17, 2024 10:50

Removed Default region retention

3f407f2

Modified comments for better understanding

c807bdd

Vishwajith-Shettigar marked this pull request as ready for review August 21, 2024 05:07

Vishwajith-Shettigar requested review from a team as code owners August 21, 2024 05:07

Vishwajith-Shettigar requested a review from BenHenning August 21, 2024 05:07

Vishwajith-Shettigar assigned adhiamboperes and unassigned Vishwajith-Shettigar Aug 21, 2024

Vishwajith-Shettigar added 2 commits August 23, 2024 10:55

Merge branch 'develop' into retain-input

ba8d992

Merge branch 'develop' into retain-input

4755ca3

adhiamboperes approved these changes Aug 26, 2024

View reviewed changes

adhiamboperes merged commit 3b7ddb9 into oppia:develop Aug 26, 2024
47 checks passed

adhiamboperes assigned Vishwajith-Shettigar and unassigned adhiamboperes Aug 26, 2024

subhajitxyz mentioned this pull request Aug 26, 2024

Develop (fork) Branch Update subhajitxyz/oppia-android#3

Merged

12 tasks

adhiamboperes mentioned this pull request Sep 17, 2024

Previous responses header collapsed state not retained across landscape changes #1592

Open

adhiamboperes mentioned this pull request Dec 9, 2024

Drag & drop drag state resets after an incorrect answer #1468

Closed

Fix #4470, #4472, #4473 : Handle configuration change using onSavedInstance. #5478

Fix #4470, #4472, #4473 : Handle configuration change using onSavedInstance. #5478

Conversation

Vishwajith-Shettigar commented Aug 7, 2024 • edited Loading

Explanation

| Drag and Drop |

| Image Region |

Essential Checklist

For UI-specific PRs only

Vishwajith-Shettigar commented Aug 10, 2024

github-actions bot commented Aug 12, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes commented Aug 12, 2024

Vishwajith-Shettigar commented Aug 12, 2024

github-actions bot commented Aug 13, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Vishwajith-Shettigar commented Aug 7, 2024 •

edited

Loading