Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5451 : java.lang.IllegalStateException - Media player has not been previously initialized #5474

Closed
wants to merge 6 commits into from
Closed

Fix #5451 : java.lang.IllegalStateException - Media player has not been previously initialized #5474

wants to merge 6 commits into from

Conversation

subhajitxyz
Copy link
Collaborator

@subhajitxyz subhajitxyz commented Jul 28, 2024 •
edited
Loading

Explanation

Fixes #5451

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@subhajitxyz subhajitxyz requested a review from a team as a code owner July 28, 2024 15:00
@github-actions GitHub Actions
Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 8996 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 4656 bytes (Removed)

Method count: 258712 (old), 258691 (new), 21 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6788 (old), 6775 (new), 13 (Removed)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 954 (old), 954 (new), 0 (No change)
  • Dimen: 1043 (old), 1030 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 378 (old), 378 (new), 0 (No change)
  • Id: 1271 (old), 1271 (new), 0 (No change)
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 378 (old), 378 (new), 0 (No change)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 848 (old), 848 (new), 0 (No change)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 8584 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 9174 bytes (Removed)
Method count: 258712 (old), 258691 (new), 21 (Removed)
Resources: 6738 (old), 6725 (new), 13 (Removed)

  • Dimen: 1039 (old), 1026 (new), 13 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 48 KiB (new), 260 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 4 bytes (Removed)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 6 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 85 KiB (new), 364 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 2 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 56 KiB (new), 260 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 63 KiB (old), 62 KiB (new), 208 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6308 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2318 bytes (Removed)

Method count: 114931 (old), 114909 (new), 22 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5944 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 7439 bytes (Removed)
Method count: 114931 (old), 114909 (new), 22 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 11 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 15 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6264 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4170 bytes (Removed)

Method count: 114927 (old), 114915 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5900 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 3677 bytes (Removed)
Method count: 114927 (old), 114915 (new), 12 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 11 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 15 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6124 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7198 bytes (Removed)

Method count: 114927 (old), 114915 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5756 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 5229 bytes (Removed)
Method count: 114927 (old), 114915 (new), 12 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 10 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 14 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

@subhajitxyz
Copy link
Collaborator Author

can anyone help me to understand why did some checks fail?

@github-actions GitHub Actions
Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 9004 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 4658 bytes (Removed)

Method count: 258712 (old), 258691 (new), 21 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6788 (old), 6775 (new), 13 (Removed)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 954 (old), 954 (new), 0 (No change)
  • Dimen: 1043 (old), 1030 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 378 (old), 378 (new), 0 (No change)
  • Id: 1271 (old), 1271 (new), 0 (No change)
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 378 (old), 378 (new), 0 (No change)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 848 (old), 848 (new), 0 (No change)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 8592 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 9161 bytes (Removed)
Method count: 258712 (old), 258691 (new), 21 (Removed)
Resources: 6738 (old), 6725 (new), 13 (Removed)

  • Dimen: 1039 (old), 1026 (new), 13 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 48 KiB (new), 260 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 4 bytes (Removed)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Removed)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 6 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 85 KiB (new), 364 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 2 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 56 KiB (new), 260 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 63 KiB (old), 62 KiB (new), 208 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6312 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2336 bytes (Removed)

Method count: 114931 (old), 114909 (new), 22 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5948 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 7430 bytes (Removed)
Method count: 114931 (old), 114909 (new), 22 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 11 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 15 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6268 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4168 bytes (Removed)

Method count: 114927 (old), 114915 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5904 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 3660 bytes (Removed)
Method count: 114927 (old), 114915 (new), 12 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 11 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 15 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 6128 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7178 bytes (Removed)

Method count: 114927 (old), 114915 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5745 (new), 13 (Removed)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 806 (old), 806 (new), 0 (No change)
  • Dimen: 778 (old), 765 (new), 13 (Removed):
    • dimen/coming_soon_text_padding_horizontal (removed)
    • dimen/coming_soon_text_padding_vertical (removed)
    • dimen/coming_soon_topic_card_layout_margin_bottom (removed)
    • dimen/coming_soon_topic_card_layout_margin_end (removed)
    • dimen/coming_soon_topic_card_layout_margin_start (removed)
    • And 8 others
  • Drawable: 340 (old), 340 (new), 0 (No change)
  • Id: 1217 (old), 1217 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 341 (old), 341 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 781 (old), 781 (new), 0 (No change)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5764 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 5228 bytes (Removed)
Method count: 114927 (old), 114915 (new), 12 (Removed)
Resources: 5715 (old), 5702 (new), 13 (Removed)

  • Dimen: 776 (old), 763 (new), 13 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 10 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Added)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Removed)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 72 KiB (new), 260 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 49 KiB (new), 208 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 14 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Removed)

theMr17
theMr17 reviewed Jul 30, 2024
View reviewed changes
domain/src/main/java/org/oppia/android/domain/audio/AudioPlayerController.kt
@@ -251,11 +260,12 @@ class AudioPlayerController @Inject constructor(
*/
fun releaseMediaPlayer() {
audioLock.withLock {
check(mediaPlayerActive) { "Media player has not been previously initialized" }
Copy link
Collaborator

@theMr17 theMr17 Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can anyone help me to understand why did some checks fail?

Hi @subhajitxyz, removal of this message is causing the check to fail. The test testController_notInitialized_releasePlayer_fails asserts this exception to be thrown with the message.

Here is the stacktrace of the failing check:
https://github.com/oppia/oppia-android/actions/runs/10132648197/job/28016870105?pr=5474#step:13:1878

@subhajitxyz subhajitxyz closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theMr17 theMr17 theMr17 left review comments

@adhiamboperes adhiamboperes Awaiting requested review from adhiamboperes adhiamboperes is a code owner automatically assigned from oppia/android-app-infrastructure-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: java.lang.IllegalStateException - Media player has not been previously initialized
2 participants
@subhajitxyz @theMr17