-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Add coming soon topic list UI & fix recommendation logic tests #5460
Fix part of #5344: Add coming soon topic list UI & fix recommendation logic tests #5460
Conversation
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 4 bytes (Removed) APK download size (estimated): 17 MiB (old), 17 MiB (new), 67 bytes (Removed) Method count: 258445 (old), 258445 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6775 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 4 bytes (Removed) Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1 bytes (Removed) Method count: 114844 (old), 114844 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 8 bytes (Removed) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change) APK download size (estimated): 10 MiB (old), 10 MiB (new), 34 bytes (Added) Method count: 114850 (old), 114850 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9 bytes (Removed) Method count: 114850 (old), 114850 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 10 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8787 bytes (Added) Method count: 258445 (old), 258479 (new), 34 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6944 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2391 bytes (Added) Method count: 114844 (old), 114866 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6580 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6560 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4441 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6196 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6588 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 5203 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6224 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 10 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8842 bytes (Added) Method count: 258445 (old), 258479 (new), 34 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6952 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2372 bytes (Added) Method count: 114844 (old), 114866 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6588 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6556 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4451 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6192 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6580 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 5213 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6216 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 10 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8842 bytes (Added) Method count: 258445 (old), 258479 (new), 34 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6952 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2372 bytes (Added) Method count: 114844 (old), 114866 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6588 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6556 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4451 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6192 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6580 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 5213 bytes (Added) Method count: 114850 (old), 114862 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6216 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 9204 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 4623 bytes (Added) Method count: 258691 (old), 258712 (new), 21 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 8784 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6604 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2506 bytes (Added) Method count: 114909 (old), 114931 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6244 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6112 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3614 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5752 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1269 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5704 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
This PR is now ready for a review, @adhiamboperes PTAL. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 9196 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 4602 bytes (Added) Method count: 258691 (old), 258712 (new), 21 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 8776 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6600 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2502 bytes (Added) Method count: 114909 (old), 114931 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6240 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6112 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3649 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5752 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1264 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5700 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
2 similar comments
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 9196 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 4602 bytes (Added) Method count: 258691 (old), 258712 (new), 21 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 8776 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6600 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2502 bytes (Added) Method count: 114909 (old), 114931 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6240 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6112 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3649 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5752 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1264 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5700 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 9196 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 4602 bytes (Added) Method count: 258691 (old), 258712 (new), 21 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6788 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 8776 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 49 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 208 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 86 KiB (new), 364 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 57 KiB (new), 260 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 63 KiB (new), 208 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 208 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6600 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2502 bytes (Added) Method count: 114909 (old), 114931 (new), 22 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 6240 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6112 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3649 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5752 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 6064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1264 bytes (Added) Method count: 114915 (old), 114927 (new), 12 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5758 (new), 13 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 5700 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 156 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 260 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 156 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 73 KiB (new), 260 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 50 KiB (new), 208 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 156 bytes (Added) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @theMr17! Please review the KDocs that I have highlighted.
app/src/main/java/org/oppia/android/app/classroom/promotedlist/ComingSoonTopicList.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/classroom/promotedlist/ComingSoonTopicList.kt
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Co-authored-by: Adhiambo Peres <[email protected]>
Co-authored-by: Adhiambo Peres <[email protected]>
@adhiamboperes PTAL. |
Explanation
Fixes part of #5344
This PR adds the coming soon topic list UI and fixes previously ignored promoted stories UI tests by correcting the test setup.
Screenshots
Phone
Tablet
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: