Fix part of #5343: Enable Code Coverage Analysis for many to one test target files #5459

Rd4dev · 2024-07-06T11:43:07Z

Explanation

Fixes part of #5343

Project

[PR 2.1 of Project 4.1]

Changes Made

Enabling code coverage analysis for many-to-one relationship test target files by aggregating the coverage reports of each related test target into a single report using the calculateAggregateCoverageReport() function.
Using the calculated aggregated coverage report to generate Markdown and HTML files.
Properly re-implemented the asynchronous flow as previous implementation though has async calls was still handling it sequentially as targets are provided one by one and made to wait until the coverage report is generated and the previous one is returned back.

Working test asynchronous flow screenshot
With static test targets provided: 2ac7b04

Low impact changes:

Not related to the current PR implementation but added few fixes along with it,

Restyled the HTML report slightly since the previous version appeared somewhat vague and empty 😶‍🌫️.
Renamed sample test name from TwoSum to AddNums, felt more appropriate and clear.

Note

I couldn't find any actual working app module file with both shared and local tests to fully test this. Instead, I mocked the behavior with a sample coverage report and tested it with test cases, assuming that both tests for the same source file would have identical line_number, lines_hit, and lines_found data.

Screenshot of current HTML report

Responsive layouts

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

…args to and make reordering possible

…re descriptive

… a long time causing TIMEOUT failures

…cts the TIMEOUT

…on the tests

…on the tests adding missed paranthesis

… then convert them to uppercase

…case removal

… fails

…see if it still fails (intended FAILURE output case)

… see if it still fails (intended FAILURE output case)

… setup

…to see if it was reflected

…s are limitations

github-actions · 2024-08-01T04:27:10Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 12 bytes (Removed)

Method count: 258712 (old), 258712 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6788 (old), 6788 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 954 (old), 954 (new), 0 (No change)
Dimen: 1043 (old), 1043 (new), 0 (No change)
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 8 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 15 bytes (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 8 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2 bytes (Added)

Method count: 114931 (old), 114931 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 8 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 1 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2 bytes (Removed)

Method count: 114927 (old), 114927 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 0 bytes (No change)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 13 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 9 bytes (Removed)

Method count: 114927 (old), 114927 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 0 bytes (No change)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @Rd4dev! I have no further concerns. Approving!

BenHenning

Thanks @Rd4dev! Had a few follow-ups--PTAL. Please reach out to me directly if you want to discuss any of these comments over a higher bandwidth channel (such as chat).

@adhiamboperes can you please confirm your open remaining comment? :)

scripts/src/java/org/oppia/android/scripts/coverage/CoverageRunner.kt

scripts/src/java/org/oppia/android/scripts/coverage/RunCoverage.kt

scripts/src/javatests/org/oppia/android/scripts/coverage/CoverageRunnerTest.kt

scripts/src/java/org/oppia/android/scripts/coverage/RunCoverage.kt

scripts/src/javatests/org/oppia/android/scripts/coverage/CoverageRunnerTest.kt

…to structure

…ture

github-actions · 2024-08-05T04:45:51Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 14 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 13 KiB (Removed)

Method count: 259120 (old), 258712 (new), 408 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6788 (old), 6788 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 954 (old), 954 (new), 0 (No change)
Dimen: 1043 (old), 1043 (new), 0 (No change)
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 14 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 13 KiB (Removed)
Method count: 259120 (old), 258712 (new), 408 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9356 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 14 KiB (Removed)

Method count: 115112 (old), 114931 (new), 181 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 9364 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 11 KiB (Removed)
Method count: 115112 (old), 114931 (new), 181 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7736 bytes (Removed)

Method count: 115108 (old), 114927 (new), 181 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 9 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 11 KiB (Removed)
Method count: 115108 (old), 114927 (new), 181 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 11 KiB (Removed)

Method count: 115108 (old), 114927 (new), 181 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5758 (old), 5758 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 778 (old), 778 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 9 KiB (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 11 KiB (Removed)
Method count: 115108 (old), 114927 (new), 181 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

…o code_coverage_many_to_one_targets

…or a file do work properly

Rd4dev · 2024-08-06T21:09:27Z

@BenHenning, added the required testRunCoverage_withMultipleTestsForFile_analysingSameFile with the latest commit and addressed all other comment reviews, can you PTAL?

oppiabot · 2024-08-06T21:12:31Z

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

BenHenning

Thanks @Rd4dev! This LGTM.

scripts/src/java/org/oppia/android/scripts/coverage/RunCoverage.kt

BenHenning · 2024-08-07T03:14:26Z

Holding off on merging this until I take a full pass first on #5461.

oppiabot · 2024-08-07T03:17:00Z

Unassigning @BenHenning since they have already approved the PR.

oppiabot · 2024-08-07T03:17:04Z

Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

BenHenning · 2024-08-07T03:57:58Z

Merging this since I took a pass on #5461.

Rd4dev added 30 commits June 28, 2024 21:46

Code Coverage M1 edge case, added arg names to specifically pick the …

d1c07cd

…args to and make reordering possible

Modified script example doc and updated the exception string to be mo…

b26ac35

…re descriptive

Added tests for edge case checks

b89d9a8

Increasing the processTimeout to 10 minutes as coverage analysis take…

23cba86

… a long time causing TIMEOUT failures

Setting processTimeout in the run coverage script to see if this affe…

e24578e

…cts the TIMEOUT

Set processTimeout for added test cases

96c2b74

Triggering Build to check TIMEOUT

349be2e

Reverting the changes just to check if these changes have any effect …

300fb90

…on the tests

Reverting the changes just to check if these changes have any effect …

181e8b2

…on the tests adding missed paranthesis

Re-introducing the changes while removing the ignore case check as we…

87926ad

… then convert them to uppercase

Re-introducing the test changes with the passed ci check with ignore …

718b065

…case removal

Trying out other unit of processTimeout value

c15d6e7

Do not merge - Updated WAIT_PROCESS_TIMEOUT_MS to x4

f417bda

Using a smaller / simpler source and test file to check if this still…

70378d6

… fails

Commenting out 1 of 2 newly added tests

9dbd7be

Using a simpler test and source file for sampleTestsDefaultFormat to …

f59c768

…see if it still fails (intended FAILURE output case)

Using a simpler test and source file for scriptTestsMarkdownFormat to…

f5663d7

… see if it still fails (intended FAILURE output case)

Checking if remvoing the 2nd test case solves the timeout to confirm

bab336e

Reverting back to original changes

2ee1bba

Trying to see if moving the declration to setup could reduce load

23b15b7

Moving scripts source and test files to setup

6f30dac

Removed any duplicate coverage file creations as they were already in…

b391b1c

… setup

Almost making compute affected tests execution time to 1 millisecond …

f684951

…to see if it was reflected

The actual compute affected test do reflect processTimeout

100d8f1

Removing lazy declaration to see if command Executor works that way

4f2d93f

Initialize command Executor reference

9886da4

Import CommandExecutor statement added

4f5d47c

Added arg names to script calls

69d4583

Trying to make it die in 1L to see if there are any actual reflection…

e82f2fd

…s are limitations

Increasing the processTimeout and commandExecutor to high values

a757fd9

adhiamboperes approved these changes Aug 1, 2024

View reviewed changes

adhiamboperes removed their assignment Aug 1, 2024

BenHenning requested changes Aug 1, 2024

View reviewed changes

BenHenning assigned adhiamboperes and Rd4dev and unassigned BenHenning Aug 1, 2024

Rd4dev added 4 commits August 2, 2024 01:31

Reference point for mock data with new repeated bazel test target pro…

824c406

…to structure

Clean up and simplification of usage of single usage entry

5ee99c0

Fix lint checks and failing test case with update to the proto strucu…

372ae95

…ture

Added missing import for BazelTestTarget

6499311

adhiamboperes removed their assignment Aug 5, 2024

Rd4dev added 2 commits August 7, 2024 01:58

Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

5e528fe

…o code_coverage_many_to_one_targets

Added the copy of local and shared test to ensure the multiple test f…

e72eec3

…or a file do work properly

oppiabot bot assigned BenHenning and unassigned Rd4dev Aug 6, 2024

BenHenning approved these changes Aug 7, 2024

View reviewed changes

oppiabot bot unassigned BenHenning Aug 7, 2024

oppiabot bot added the PR: LGTM label Aug 7, 2024

oppiabot bot assigned Rd4dev Aug 7, 2024

Rd4dev mentioned this pull request Aug 7, 2024

Fix part of #5343: Enable Coverage Generation for a list of files #5461

Merged

6 tasks

BenHenning merged commit 8099260 into develop Aug 7, 2024
24 checks passed

BenHenning deleted the code_coverage_many_to_one_targets branch August 7, 2024 03:58

Fix part of #5343: Enable Code Coverage Analysis for many to one test target files #5459

Fix part of #5343: Enable Code Coverage Analysis for many to one test target files #5459

Conversation

Rd4dev commented Jul 6, 2024 • edited by BenHenning Loading

Explanation

Project

Changes Made

Note

Screenshot of current HTML report

Essential Checklist

For UI-specific PRs only

github-actions bot commented Aug 1, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Rd4dev commented Jul 6, 2024 •

edited by BenHenning

Loading