Fix part of #5343: Building proto with coverage results for data processing #5439

Rd4dev · 2024-06-21T20:38:06Z

Explanation

Fixes part of #5343

Project

[PR 1.4 of Project 4.1]

Changes Made

Introduced coverage.proto to store the coverage data generated during coverage analysis.
Parsed coverage data according to the LCOV (geninfo) file format specifications: LCOV geninfo specifications
This maps the Bazel test target to the corresponding SF: source file path and filters the data to generate the Coverage Report proto that will only the coverage of the tests related to the single source file.
With the previous implementation in PR 1.3 to get the related LocalTest and Test file mappings, we utilize that to run coverage for both the test and return them as a list of Coverage Report protos.

To Note:

Only the app module has the multi test file case.
But as of date, the many app module coverage executions fail.
So to test acquiring multi test coverage execution as list of Coverage Report Proto, I hardcoded and tested the implementation [hardcoded comment] (just for testing the actual code wouldn't have that)

Result:
A representation of the list of Coverage Report proto is presented below:

This is the output on running 2 hardcoded test cases:
math:MathModelTest and math:FloatExtensionsTest

List of Coverage Report

Parsed Coverage Data File: /home/rddev/.../bazel-out/.../util/parser/math/MathModelTest/coverage.dat
Parsed Coverage Data File: /home/rddev/.../bazel-out/.../util/math/FloatExtensionsTest/coverage.dat
Coverage Data List: [bazel_test_target: "//utility/src/test/java/org/oppia/android/util/parser/math:MathModelTest"
covered_file {
  file_path: "utility/src/main/java/org/oppia/android/util/parser/math/MathModel.kt"
  file_sha1_hash: "37eb0c6a3a16c300da100e245e7d320c61cc008f"
  covered_line {
    line_number: 14
    coverage: FULL
  }
  covered_line {
    line_number: 15
    coverage: FULL
  }
  covered_line {
    line_number: 16
    coverage: FULL
  }
  covered_line {
    line_number: 17
    coverage: FULL
  }
  covered_line {
    line_number: 21
    coverage: FULL
  }
  covered_line {
    line_number: 33
    coverage: FULL
  }
  covered_line {
    line_number: 34
    coverage: FULL
  }
  covered_line {
    line_number: 35
    coverage: FULL
  }
  covered_line {
    line_number: 36
    coverage: FULL
  }
  covered_line {
    line_number: 41
    coverage: FULL
  }
  covered_line {
    line_number: 42
    coverage: FULL
  }
  covered_line {
    line_number: 43
    coverage: FULL
  }
  covered_line {
    line_number: 44
    coverage: FULL
  }
  covered_line {
    line_number: 45
    coverage: FULL
  }
  covered_line {
    line_number: 46
    coverage: FULL
  }
  covered_line {
    line_number: 47
    coverage: FULL
  }
  covered_line {
    line_number: 49
    coverage: FULL
  }
  covered_line {
    line_number: 58
    coverage: FULL
  }
  covered_line {
    line_number: 59
    coverage: FULL
  }
  lines_found: 19
  lines_hit: 19
  function_coverage {
    line_number: 58
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature$Companion::createSignature$utility_src_main_java_org_oppia_android_util_parser_math_math_latex_model_kt (Ljava/lang/String;FZ)Lorg/oppia/android/util/parser/math/MathModel$MathModelSignature;"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 33
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature:: (Ljava/lang/String;IZ)V"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 35
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature::getLineHeightHundredX ()I"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 34
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature::getRawLatex ()Ljava/lang/String;"
    execution_count: 0
    coverage: NONE
  }
  function_coverage {
    line_number: 36
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature::getUseInlineRendering ()Z"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 41
    function_name: "org/oppia/android/util/parser/math/MathModel$MathModelSignature::updateDiskCacheKey (Ljava/security/MessageDigest;)V"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 14
    function_name: "org/oppia/android/util/parser/math/MathModel:: (Ljava/lang/String;FZ)V"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 16
    function_name: "org/oppia/android/util/parser/math/MathModel::getLineHeight ()F"
    execution_count: 0
    coverage: NONE
  }
  function_coverage {
    line_number: 15
    function_name: "org/oppia/android/util/parser/math/MathModel::getRawLatex ()Ljava/lang/String;"
    execution_count: 0
    coverage: NONE
  }
  function_coverage {
    line_number: 17
    function_name: "org/oppia/android/util/parser/math/MathModel::getUseInlineRendering ()Z"
    execution_count: 0
    coverage: NONE
  }
  function_coverage {
    line_number: 21
    function_name: "org/oppia/android/util/parser/math/MathModel::toKeySignature ()Lorg/oppia/android/util/parser/math/MathModel$MathModelSignature;"
    execution_count: 1
    coverage: FULL
  }
  functions_found: 11
  functions_hit: 7
  branch_coverage {
    line_number: 46
    block_number: 0
    branch_number: 0
    hit_count: 1
    coverage: FULL
  }
  branch_coverage {
    line_number: 46
    block_number: 0
    branch_number: 1
    hit_count: 1
    coverage: FULL
  }
  branches_found: 2
  branches_hit: 2
}
, bazel_test_target: "//utility/src/test/java/org/oppia/android/util/math:FloatExtensionsTest"
covered_file {
  file_path: "utility/src/main/java/org/oppia/android/util/math/FloatExtensions.kt"
  file_sha1_hash: "178a2d84e9182a11b41adf34abc0a92a7d365f50"
  covered_line {
    line_number: 28
    coverage: FULL
  }
  covered_line {
    line_number: 36
    coverage: FULL
  }
  covered_line {
    line_number: 43
    coverage: FULL
  }
  lines_found: 3
  lines_hit: 3
  function_coverage {
    line_number: 36
    function_name: "org/oppia/android/util/math/FloatExtensionsKt::isApproximatelyEqualTo (DD)Z"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 28
    function_name: "org/oppia/android/util/math/FloatExtensionsKt::isApproximatelyEqualTo (FF)Z"
    execution_count: 1
    coverage: FULL
  }
  function_coverage {
    line_number: 43
    function_name: "org/oppia/android/util/math/FloatExtensionsKt::toPlainString (D)Ljava/lang/String;"
    execution_count: 1
    coverage: FULL
  }
  functions_found: 3
  functions_hit: 3
  branch_coverage {
    line_number: 28
    block_number: 0
    branch_number: 0
    hit_count: 1
    coverage: FULL
  }
  branch_coverage {
    line_number: 28
    block_number: 0
    branch_number: 1
    hit_count: 1
    coverage: FULL
  }
  branch_coverage {
    line_number: 36
    block_number: 0
    branch_number: 0
    hit_count: 1
    coverage: FULL
  }
  branch_coverage {
    line_number: 36
    block_number: 0
    branch_number: 1
    hit_count: 1
    coverage: FULL
  }
  branches_found: 4
  branches_hit: 4
}
]

Representation in Protobuf

Function Coverage: Interpreted execution counts to determine coverage status. Any execution count greater than 0 signifies full coverage, otherwise considered null.
Branch Coverage: Determined coverage based on the recorded hit count for each branch. A hit count greater than 0 denotes full coverage, otherwise marked as null.

Usage:
The stored proto will be used to generate coverage reports in md and HTML formats [to be handled in PR 1.5]

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

… data file path

… file content and its related test content in the provided subpackage

…d test files with corresponding build configurations and content

…the contents as byte array

…nary

…eturning coverage data

… arguments and use them

… methods

…e in testing the utilities

…o code_coverage_bazel_command_execution

…instead of test target

Rd4dev · 2024-06-26T08:14:13Z

Just to check: are you planning to change the script to take a source file and derive the test targets from that?

Yeah @BenHenning, that is what is implemented in the #5433, developer inputs a sourceFile.kt and we map them to test targets. (this was decided based on user experience)

Edit: If that question is something related to M2 (I am right now uncertain which would be the best strategy and that would be based on the ci runs. If we could get the list of changed files (not affected), then that that should be straightforward with the existing script.

Rd4dev · 2024-06-26T10:45:17Z

The suggestion to add test cases as in #5433 (comment) are implemented in this PR with [commit]

Rd4dev · 2024-06-26T10:57:36Z

Hi @adhiamboperes, this PR is now ready for review, addressed all the review comments Ben left. Can you PTAL!

oppiabot · 2024-06-26T11:00:40Z

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @Rd4dev. I took a full pass and the implementation looks clean, and I think the structure of the coverage.proto looks great.

Rd4dev · 2024-06-27T00:17:22Z

Thank you so much @adhiamboperes 😃

github-actions · 2024-06-27T03:29:27Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 8 bytes (Removed)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 3 bytes (Added)

Method count: 227007 (old), 227007 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 16 MiB (old), 16 MiB (new), 8 bytes (Removed)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 28 bytes (Removed)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

APK download size (estimated): 9184 KiB (old), 9184 KiB (new), 31 bytes (Added)

Method count: 101341 (old), 101341 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9064 KiB (old), 9064 KiB (new), 7 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

APK download size (estimated): 9169 KiB (old), 9169 KiB (new), 30 bytes (Removed)

Method count: 101341 (old), 101341 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)
APK download size (estimated): 9053 KiB (old), 9053 KiB (new), 37 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

APK download size (estimated): 9169 KiB (old), 9169 KiB (new), 1 bytes (Added)

Method count: 101341 (old), 101341 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9053 KiB (old), 9053 KiB (new), 38 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Rd4dev · 2024-06-27T04:57:17Z

@adhiamboperes, also I am unsure how to get this pass the unresolved conversations, to get it merged?

DubeySandeep · 2024-06-27T06:25:35Z

@seanlip Can you help get this PR merged? @BenHenning is on leave and was fine with the PR changes.

seanlip · 2024-06-27T06:33:13Z

Yup, I think that's fine. I'll see if I can merge this.

Ben's away, and Adhiambo has approved. See comment that Sandeep linked to.

seanlip · 2024-06-27T06:34:17Z

@adhiamboperes Could you please check the previous conversations and resolve them to confirm they are resolved, since that's a requirement for merge? Thanks.

adhiamboperes · 2024-06-27T07:37:56Z

@Rd4dev, there are two comments to respond to, but I have verified everything else as addressed and resolved them.

Rd4dev · 2024-06-27T07:43:41Z

@Rd4dev, there are two comments to respond to, but I have verified everything else as addressed and resolved them.

Thanks @adhiamboperes,

Replied to the conversation on non-existing file: https://github.com/oppia/oppia-android/pull/5439/files/25a064e555894a21b18a0c5aa759e9f8e28b3a19#r1656625309
And resolved the conversation I opened: https://github.com/oppia/oppia-android/pull/5439/files/bc9a5c084cbcebb97ed449c624489215a14373e9#r1656590468 (as it was implemented)

adhiamboperes · 2024-06-27T08:30:53Z

Thanks @Rd4dev. Everything looks good.

Rd4dev added 30 commits June 13, 2024 20:00

Fix lint new line and kdoc checks

6ec35a7

Execute Bazel Command to run coverage on the test target

1ec224a

Parse the coverage execution result to acquire the generated coverage…

ee92168

… data file path

Implemented functionality to TestBazelWorkspace utility to add source…

075c77c

… file content and its related test content in the provided subpackage

Sample Test data and Listing all contents

d0519d6

Added Test for BazelClient - for sample target and non target executions

b15b7bb

Added Coverage Runner functionality tests

f441d11

Added tests for the RunCoverageForTestTarget utility

cc86309

Replaced Java Test Sources with Kotlin Sources

4a6073b

Fix Static Checks / Lint warnings

13534a1

Fix Buildifier Lint checks

fc52d82

Added tests for TestBazelWorkspaceTest to check addition of source an…

0226baa

…d test files with corresponding build configurations and content

Fix Lint warnings with TestBazelWorkspaceTest

2fe7485

Fix Regex Pattern checks

bd683b5

Prototyped parsing and reading the extracted file data as byte array

d410d17

Updated the runCoverageForTestTarget to parse the data file and read …

ece147a

…the contents as byte array

Updated Bazel Client Tests with updated execution to return byte array

b101ec8

Updated BazelClientTest for ParseCoverageDataFile and readDatFileAsBi…

5db0650

…nary

Updated CoverageRunnerTest to check with updated getCoverage result r…

87be114

…eturning coverage data

Updated RunCoverageForTestTargetTest to check the returned coverage data

456e81b

Update kdoc to match the function paramaters

2c65524

Removing suspend while keeping the async operations

62f9e1d

Updated RunCoverageForTestTarget to take in custom process timeout as…

5e6d2ef

… arguments and use them

Initialized bazelClient using lazy field

31b6401

Adjusted visibility and removed unnecessary documentation for private…

81d6855

… methods

Revoking visibility of bazelClient functions as that is called outsid…

6cb1da7

…e in testing the utilities

Fix Lint Check issues

b41fb01

Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

e66ac12

…o code_coverage_bazel_command_execution

Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

c646840

…o code_coverage_bazel_command_execution

Introduce new script RunCoverage.kt to later take in source filename …

1ffc83d

…instead of test target

BenHenning removed their assignment Jun 26, 2024

Added tests for local and sharedTests separately

cf405c6

Fix Lint check, missed separator

88f286b

oppiabot bot assigned adhiamboperes and unassigned Rd4dev Jun 26, 2024

Fix Coverage Runner Test

32d9ae4

Base automatically changed from code_coverage_using_filename to develop June 26, 2024 13:55

Rd4dev added 2 commits June 26, 2024 21:05

Resolved conflicts with develop branch

266d0f4

Resolved conflicting overloads

a0bc41c

adhiamboperes approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'develop' into code_coverage_store_as_proto

a781919

adhiamboperes assigned Rd4dev and unassigned adhiamboperes Jun 26, 2024

seanlip assigned adhiamboperes Jun 27, 2024

adhiamboperes merged commit c5de68b into develop Jun 27, 2024
25 checks passed

adhiamboperes deleted the code_coverage_store_as_proto branch June 27, 2024 08:31

Fix part of #5343: Building proto with coverage results for data processing #5439

Fix part of #5343: Building proto with coverage results for data processing #5439

Conversation

Rd4dev commented Jun 21, 2024 • edited Loading

Explanation

Project

Changes Made

Essential Checklist

For UI-specific PRs only

Rd4dev commented Jun 26, 2024 • edited Loading

Rd4dev commented Jun 26, 2024 • edited Loading

Rd4dev commented Jun 26, 2024

oppiabot bot commented Jun 26, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

Rd4dev commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Rd4dev commented Jun 27, 2024

DubeySandeep commented Jun 27, 2024

seanlip commented Jun 27, 2024

seanlip commented Jun 27, 2024 • edited Loading

adhiamboperes commented Jun 27, 2024

Rd4dev commented Jun 27, 2024 • edited Loading

adhiamboperes commented Jun 27, 2024

Rd4dev commented Jun 21, 2024 •

edited

Loading

Rd4dev commented Jun 26, 2024 •

edited

Loading

Rd4dev commented Jun 26, 2024 •

edited

Loading

seanlip commented Jun 27, 2024 •

edited

Loading

Rd4dev commented Jun 27, 2024 •

edited

Loading