Fix part of #5343: Update the test exemption check script & its exemption format #5426

Rd4dev · 2024-06-18T09:29:55Z

Explanation

Fixes part of #5343

Project
[PR 1.2 of Project 4.1]
This PR is based on develop as it had no other dependency with other PRs.

Changes Implemented

This PR implements updates to enhance the handling of file exemptions and code coverage settings:

Updates script_exemptions.proto to support two possible states:
- Exemption from requiring a test file (current behavior).
- Override of the minimum code coverage to meet a specific percentage (including 0%).
Aligns test_file_exemptions.textproto with the new proto format.
Modifies TestFileCheck.kt to integrate the updated proto format.

Project Context

In Project 4.1, we are introducing code coverage capabilities where certain files may require exemptions from the default minimum code coverage percentage. These exemptions can now be managed in test_file_exemptions.textproto by setting the override_min_coverage_percentage.

Implementation Details

Initially, I explored using the TodoOpenCheck regeneration structure to implement these changes. However, due to significant differences in regeneration requirements (creating a new proto format to regenerate the exemptions list), conflicts arose with generate_test_file_assets_list_from_text_protos.

Given that the regeneration process is solely aimed at rebuilding the textproto file and no longer serves any other purpose in this project, I opted to manually compile a list of exempted files and used it to generate the new proto format. I then transferred this newly generated format to the textproto file. The regeneration implementation can be found in my local test_exemption branch

Post-generation, the regeneration functionality was removed, as it no longer aligns with the project's needs. Further validation and adjustments, if necessary, will be discussed with Ben and implemented.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

…ith test_file_exemptions.textproto

…e_not_required flag

Rd4dev · 2024-06-18T16:29:34Z

@BenHenning can you PTAL!

…o code_coverage_test_file_exemption_rebuild

…xtproto

github-actions · 2024-06-20T03:28:43Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 0 bytes (No change)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 9 bytes (Removed)

Method count: 221791 (old), 221791 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 0 bytes (No change)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 14 bytes (Added)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

APK download size (estimated): 9150 KiB (old), 9150 KiB (new), 21 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9030 KiB (old), 9030 KiB (new), 13 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9135 KiB (old), 9135 KiB (new), 31 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9019 KiB (old), 9019 KiB (new), 4 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9136 KiB (old), 9136 KiB (new), 21 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)
APK download size (estimated): 9020 KiB (old), 9020 KiB (new), 21 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

BenHenning

Thanks @Rd4dev! The approach LGTM--just had one comment for adding a new test to verify the "do not exempt" behavior that TestFileCheck now has--PTAL.

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt

github-actions · 2024-06-21T03:38:54Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 0 bytes (No change)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 9 bytes (Removed)

Method count: 221791 (old), 221791 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 0 bytes (No change)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 14 bytes (Added)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed)

APK download size (estimated): 9150 KiB (old), 9150 KiB (new), 21 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9030 KiB (old), 9030 KiB (new), 13 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9135 KiB (old), 9135 KiB (new), 31 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Removed)
APK download size (estimated): 9019 KiB (old), 9019 KiB (new), 4 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9136 KiB (old), 9136 KiB (new), 21 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)
APK download size (estimated): 9020 KiB (old), 9020 KiB (new), 21 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

…ption not exempted from test file check

…o code_coverage_test_file_exemption_rebuild

Rd4dev · 2024-06-21T07:12:06Z

@BenHenning added the test case to verify that a min coverage exemption results in the file not being exempted, PTAL!

oppiabot · 2024-06-21T07:15:10Z

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

BenHenning

Thanks @Rd4dev! Took another pass--PTAL.

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt

scripts/src/javatests/org/oppia/android/scripts/testfile/TestFileCheckTest.kt

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt

github-actions · 2024-06-22T02:59:16Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 0 bytes (No change)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 11 bytes (Removed)

Method count: 221791 (old), 221791 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 4 bytes (Added)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 18 bytes (Removed)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Added)

APK download size (estimated): 9150 KiB (old), 9150 KiB (new), 0 bytes (No change)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9030 KiB (old), 9030 KiB (new), 4 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)

APK download size (estimated): 9135 KiB (old), 9135 KiB (new), 9 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9019 KiB (old), 9019 KiB (new), 17 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9136 KiB (old), 9136 KiB (new), 7 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9020 KiB (old), 9020 KiB (new), 1 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

… min coverage percentage files too

…ithub.com/Rd4dev/oppia-android into code_coverage_test_file_exemption_rebuild

Rd4dev · 2024-06-22T08:08:08Z

Thanks for the review and suggestions @BenHenning, added the required test cases for validating coverage exemption checks too, can you PTAL!

oppiabot · 2024-06-22T08:11:12Z

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

github-actions · 2024-06-23T02:51:20Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 0 bytes (No change)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 7 bytes (Added)

Method count: 221791 (old), 221791 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 8 bytes (Added)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 28 bytes (Removed)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Added)

APK download size (estimated): 9150 KiB (old), 9150 KiB (new), 2 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9030 KiB (old), 9030 KiB (new), 9 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)

APK download size (estimated): 9135 KiB (old), 9135 KiB (new), 24 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9019 KiB (old), 9019 KiB (new), 2 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9136 KiB (old), 9136 KiB (new), 15 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9020 KiB (old), 9020 KiB (new), 6 bytes (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

BenHenning

Thanks @Rd4dev! This LGTM.

scripts/src/javatests/org/oppia/android/scripts/testfile/TestFileCheckTest.kt

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt

BenHenning · 2024-06-23T06:50:58Z

Feel free to merge this @Rd4dev if you don't intend to make any follow-up changes. If you do make follow-up changes, please assign back so I can look at them.

oppiabot · 2024-06-23T06:53:27Z

Assigning @adhiamboperes for code owner reviews. Thanks!

Rd4dev · 2024-06-23T16:20:20Z

Hey @BenHenning, I removed the kDocs for the private methods in TestFileCheck.kt. Can you PTAL? Also, I'm wondering if I can merge this if it's not from upstream?

oppiabot · 2024-06-23T16:23:25Z

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

github-actions · 2024-06-24T04:08:23Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 4 bytes (Added)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 17 bytes (Removed)

Method count: 221791 (old), 221791 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 911 (new), 0 (No change)
Dimen: 994 (old), 994 (new), 0 (No change)
Drawable: 373 (old), 373 (new), 0 (No change)
Id: 1206 (old), 1206 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 368 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 805 (new), 0 (No change)
Style: 816 (old), 816 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 8 bytes (Added)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 26 bytes (Removed)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Added)

APK download size (estimated): 9150 KiB (old), 9150 KiB (new), 3 bytes (Removed)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9030 KiB (old), 9030 KiB (new), 0 bytes (No change)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)

APK download size (estimated): 9135 KiB (old), 9135 KiB (new), 14 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 4 bytes (Added)
APK download size (estimated): 9019 KiB (old), 9019 KiB (new), 18 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 0 bytes (No change)

APK download size (estimated): 9136 KiB (old), 9136 KiB (new), 13 bytes (Added)

Method count: 99436 (old), 99436 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 767 (new), 0 (No change)
Dimen: 722 (old), 722 (new), 0 (No change)
Drawable: 333 (old), 333 (new), 0 (No change)
Id: 1148 (old), 1148 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 327 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 736 (new), 0 (No change)
Style: 457 (old), 457 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 8 bytes (Added)
APK download size (estimated): 9020 KiB (old), 9020 KiB (new), 20 bytes (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

BenHenning

Thanks @Rd4dev! Seems fine to merge, so going ahead and merging it. Latest changes LGTM.

Update the test exemption check script & its exemption format along w…

2c80614

…ith test_file_exemptions.textproto

Rd4dev requested a review from a team as a code owner June 18, 2024 09:29

Rd4dev requested a review from adhiamboperes June 18, 2024 09:29

Rd4dev mentioned this pull request Jun 18, 2024

[Feature Request]: Introduce support for code coverage & enforcement (GSoC'24 4.1) #5343

Closed

Fix: Filter TestFileExemptionList to include only files with test_fil…

3c8008a

…e_not_required flag

oppiabot bot assigned BenHenning Jun 18, 2024

Rd4dev added 4 commits June 18, 2024 23:38

Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

aba4d33

…o code_coverage_test_file_exemption_rebuild

Trigger re-checks for NetworkLoggingInterceptorTest failure status

0fb3c44

Resolved Merge conflict in scripts/assets/test_file_exemptions.textproto

d3359fc

Resolve Merge conflicts with new additions to test_file_exemptions.te…

9b7bf5a

…xtproto

BenHenning requested changes Jun 20, 2024

View reviewed changes

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt Outdated Show resolved Hide resolved

BenHenning assigned Rd4dev and unassigned BenHenning Jun 20, 2024

Rd4dev added 3 commits June 21, 2024 11:01

Restructured TestFileCheck to enable testing of min_coverage set exem…

9b90ca2

…ption not exempted from test file check

Fix Lint Checks and Kdoc additions

dd24d3c

Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

760120c

…o code_coverage_test_file_exemption_rebuild

oppiabot bot assigned BenHenning and unassigned Rd4dev Jun 21, 2024

Rd4dev requested a review from BenHenning June 21, 2024 08:38

BenHenning requested changes Jun 21, 2024

View reviewed changes

BenHenning assigned Rd4dev and unassigned BenHenning Jun 21, 2024

Merge branch 'develop' into code_coverage_test_file_exemption_rebuild

a4b0933

Added test cases to check the test exemption doesn't exclude override…

8522410

… min coverage percentage files too

Rd4dev added 2 commits June 22, 2024 12:55

Merge branch 'code_coverage_test_file_exemption_rebuild' of https://g…

4ba6b3d

…ithub.com/Rd4dev/oppia-android into code_coverage_test_file_exemption_rebuild

Fix punctuation and unusued import removal

29346c2

oppiabot bot assigned BenHenning and unassigned Rd4dev Jun 22, 2024

Rd4dev added 3 commits June 22, 2024 14:58

Renamed test cases to match standard file practice used

b637d64

Added missing curly braces

2bf98fe

Trigger commit for Unexpected HTTP response: 500 erro in CI JDK setup

d367c7b

BenHenning approved these changes Jun 23, 2024

View reviewed changes

scripts/src/javatests/org/oppia/android/scripts/testfile/TestFileCheckTest.kt Outdated Show resolved Hide resolved

scripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt Outdated Show resolved Hide resolved

BenHenning assigned Rd4dev and unassigned BenHenning Jun 23, 2024

oppiabot bot assigned adhiamboperes Jun 23, 2024

Removed KDocs on the private methods

cd0b55b

oppiabot bot assigned BenHenning and unassigned Rd4dev Jun 23, 2024

BenHenning approved these changes Jun 24, 2024

View reviewed changes

BenHenning merged commit 92a561f into oppia:develop Jun 24, 2024
25 checks passed

Fix part of #5343: Update the test exemption check script & its exemption format #5426

Fix part of #5343: Update the test exemption check script & its exemption format #5426

Conversation

Rd4dev commented Jun 18, 2024 • edited Loading

Explanation

Changes Implemented

Project Context

Implementation Details

Essential Checklist

For UI-specific PRs only

Rd4dev commented Jun 18, 2024

github-actions bot commented Jun 20, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

BenHenning left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 21, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Rd4dev commented Jun 18, 2024 •

edited

Loading