Prototype Multiple Classrooms UI #5424

theMr17 · 2024-06-17T13:15:36Z

Explanation

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

This moves the codebase to using the recommended single top-level Dagger library rather than replicating it in a bunch of different places.

This is needed for downstream work. It also includes ensuring that Guava JRE can never be used (since only Android should ever be referenced by the production app build).

There's some cleanup work needed beyond this, but this is the core change to introduce Kotlin 1.6 support (at least for dev builds). Moshi needed to be upgraded due to a metadata incompatibility when moving over to Kotlin 1.6.

rules_kotlin moved its imports into more structured bzl files to load, so this updates all references in the codebase to point to the correct locations (which removes debug warnings that show up on the CLI).

Moshi 1.14 pulls in kotlin-reflect 1.7.0 which isn't compatible with the rules_kotlin version we need for Bazel 4.x. Relatedly, this downgrades rules_kotlin to 1.5.0, but it fortunately keeps all other changes needed for 1.7.1 (which will be used in a later PR). Some code fixes were needed, too, for unknown reasons (since the build should've been using Kotlin 1.6 before). Either way, these fixes seem reasonable.

Fixed all warnings that the compiler warned about. Removed ViewModelProvider & fixed state leaking entirely by moving away from Jetpack's ViewModel as a base class (since we aren't correctly using that correctly).

Enables Java warnings-as-errors, though this doesn't yet apply to kapt-generated code (such as the code from Dagger), but those warnings were still manually fixed. This also fixes a small import warning in a proto file, and warnings when building oppia_dev_kitkat (by updating the main dex list, but it's likely the build doesn't work anymore, anyway, and it's hard to test locally).

There's a race condition when building large numbers of app tests simultaneously that can lead to build failures. While the CI runs are resilient now to this failure, it'd be better to try and fix it. This removes the last non-AndroidX dependency from the codebase with hopes that it helps reduce the likelihood of the error (though there are no dependencies on it, so it's unlikely).

Conflicts: WORKSPACE app/build.gradle app/src/main/java/org/oppia/android/app/viewmodel/ViewModelBridgeFactory.kt config/proguard/kotlin-proguard-rules.pro domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/AnalyticsController.kt scripts/assets/maven_dependencies.textproto scripts/src/java/org/oppia/android/scripts/common/BUILD.bazel scripts/src/java/org/oppia/android/scripts/common/CommandExecutorImpl.kt scripts/src/java/org/oppia/android/scripts/license/MavenDependenciesRetriever.kt scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependencies.kt scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependency.kt scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependencyTree.kt third_party/BUILD.bazel third_party/maven_install.json third_party/versions.bzl tools/kotlin/BUILD.bazel utility/build.gradle utility/src/main/java/org/oppia/android/util/parser/image/UrlImageParser.kt

…xternal

Conflicts: build.gradle data/build.gradle domain/build.gradle third_party/maven_install.json

…l-and-kotlin Conflicts: WORKSPACE app/BUILD.bazel app/src/main/java/org/oppia/android/app/activity/route/BUILD.bazel app/src/main/java/org/oppia/android/app/application/BUILD.bazel app/src/main/java/org/oppia/android/app/application/alpha/BUILD.bazel app/src/main/java/org/oppia/android/app/application/alphakenya/BUILD.bazel app/src/main/java/org/oppia/android/app/application/beta/BUILD.bazel app/src/main/java/org/oppia/android/app/application/dev/BUILD.bazel app/src/main/java/org/oppia/android/app/application/ga/BUILD.bazel app/src/main/java/org/oppia/android/app/application/testing/BUILD.bazel app/src/main/java/org/oppia/android/app/notice/testing/BUILD.bazel app/src/main/java/org/oppia/android/app/player/exploration/testing/BUILD.bazel app/src/main/java/org/oppia/android/app/shim/BUILD.bazel app/src/main/java/org/oppia/android/app/translation/BUILD.bazel app/src/main/java/org/oppia/android/app/translation/testing/BUILD.bazel app/src/main/java/org/oppia/android/app/utility/datetime/BUILD.bazel app/src/main/java/org/oppia/android/app/utility/lifecycle/BUILD.bazel app/src/main/java/org/oppia/android/app/utility/math/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/administratorcontrols/learneranalytics/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/customview/interaction/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/databinding/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/devoptions/mathexpressionparser/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/notice/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/player/exploration/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/player/state/BUILD.bazel app/src/sharedTest/java/org/oppia/android/app/splash/BUILD.bazel app/src/test/java/org/oppia/android/app/activity/BUILD.bazel app/src/test/java/org/oppia/android/app/activity/route/BUILD.bazel app/src/test/java/org/oppia/android/app/application/alpha/BUILD.bazel app/src/test/java/org/oppia/android/app/application/beta/BUILD.bazel app/src/test/java/org/oppia/android/app/application/dev/BUILD.bazel app/src/test/java/org/oppia/android/app/application/ga/BUILD.bazel app/src/test/java/org/oppia/android/app/application/testing/BUILD.bazel app/src/test/java/org/oppia/android/app/testing/activity/BUILD.bazel app/src/test/java/org/oppia/android/app/translation/BUILD.bazel app/src/test/java/org/oppia/android/app/translation/testing/BUILD.bazel app/src/test/java/org/oppia/android/app/utility/math/BUILD.bazel config/proguard/kotlin-proguard-rules.pro data/BUILD.bazel data/build.gradle data/src/main/java/org/oppia/android/data/backends/gae/BUILD.bazel data/src/main/java/org/oppia/android/data/backends/gae/api/BUILD.bazel data/src/main/java/org/oppia/android/data/backends/gae/model/BUILD.bazel data/src/main/java/org/oppia/android/data/persistence/BUILD.bazel data/src/test/java/org/oppia/android/data/persistence/BUILD.bazel domain/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/algebraicexpressioninput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/continueinteraction/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/dragAndDropSortInput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/fractioninput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/imageClickInput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/itemselectioninput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/mathequationinput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/multiplechoiceinput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/numberwithunits/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/numericexpressioninput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/numericinput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/ratioinput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/classify/rules/textinput/BUILD.bazel domain/src/main/java/org/oppia/android/domain/clipboard/BUILD.bazel domain/src/main/java/org/oppia/android/domain/exploration/testing/BUILD.bazel domain/src/main/java/org/oppia/android/domain/feedbackreporting/BUILD.bazel domain/src/main/java/org/oppia/android/domain/locale/BUILD.bazel domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/testing/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/exceptions/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/logscheduler/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/loguploader/BUILD.bazel domain/src/main/java/org/oppia/android/domain/profile/BUILD.bazel domain/src/main/java/org/oppia/android/domain/spotlight/BUILD.bazel domain/src/main/java/org/oppia/android/domain/testing/oppialogger/loguploader/BUILD.bazel domain/src/main/java/org/oppia/android/domain/translation/BUILD.bazel domain/src/test/java/org/oppia/android/domain/classify/rules/algebraicexpressioninput/BUILD.bazel domain/src/test/java/org/oppia/android/domain/classify/rules/mathequationinput/BUILD.bazel domain/src/test/java/org/oppia/android/domain/classify/rules/numericexpressioninput/BUILD.bazel domain/src/test/java/org/oppia/android/domain/clipboard/BUILD.bazel domain/src/test/java/org/oppia/android/domain/exploration/BUILD.bazel domain/src/test/java/org/oppia/android/domain/exploration/lightweightcheckpointing/BUILD.bazel domain/src/test/java/org/oppia/android/domain/exploration/testing/BUILD.bazel domain/src/test/java/org/oppia/android/domain/hintsandsolution/BUILD.bazel domain/src/test/java/org/oppia/android/domain/locale/BUILD.bazel domain/src/test/java/org/oppia/android/domain/onboarding/BUILD.bazel domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/testing/BUILD.bazel domain/src/test/java/org/oppia/android/domain/oppialogger/loguploader/BUILD.bazel domain/src/test/java/org/oppia/android/domain/question/BUILD.bazel domain/src/test/java/org/oppia/android/domain/translation/BUILD.bazel instrumentation/src/java/org/oppia/android/instrumentation/application/BUILD.bazel instrumentation/src/javatests/org/oppia/android/instrumentation/application/BUILD.bazel scripts/assets/maven_dependencies.textproto scripts/src/java/org/oppia/android/scripts/ci/ComputeAffectedTests.kt scripts/src/java/org/oppia/android/scripts/common/BUILD.bazel scripts/src/java/org/oppia/android/scripts/common/CommandExecutorImpl.kt scripts/src/java/org/oppia/android/scripts/common/GitClient.kt testing/BUILD.bazel testing/src/main/java/org/oppia/android/testing/data/BUILD.bazel testing/src/main/java/org/oppia/android/testing/espresso/BUILD.bazel testing/src/main/java/org/oppia/android/testing/logging/BUILD.bazel testing/src/main/java/org/oppia/android/testing/network/BUILD.bazel testing/src/main/java/org/oppia/android/testing/platformparameter/BUILD.bazel testing/src/main/java/org/oppia/android/testing/robolectric/BUILD.bazel testing/src/main/java/org/oppia/android/testing/threading/BUILD.bazel testing/src/main/java/org/oppia/android/testing/time/BUILD.bazel testing/src/test/java/org/oppia/android/testing/data/BUILD.bazel testing/src/test/java/org/oppia/android/testing/junit/BUILD.bazel testing/src/test/java/org/oppia/android/testing/logging/BUILD.bazel testing/src/test/java/org/oppia/android/testing/networking/BUILD.bazel testing/src/test/java/org/oppia/android/testing/threading/BUILD.bazel third_party/BUILD.bazel third_party/maven_install.json third_party/versions.bzl utility/BUILD.bazel utility/src/main/java/org/oppia/android/util/accessibility/BUILD.bazel utility/src/main/java/org/oppia/android/util/caching/BUILD.bazel utility/src/main/java/org/oppia/android/util/caching/testing/BUILD.bazel utility/src/main/java/org/oppia/android/util/data/BUILD.bazel utility/src/main/java/org/oppia/android/util/gcsresource/BUILD.bazel utility/src/main/java/org/oppia/android/util/locale/BUILD.bazel utility/src/main/java/org/oppia/android/util/locale/testing/BUILD.bazel utility/src/main/java/org/oppia/android/util/logging/BUILD.bazel utility/src/main/java/org/oppia/android/util/logging/firebase/BUILD.bazel utility/src/main/java/org/oppia/android/util/logging/performancemetrics/BUILD.bazel utility/src/main/java/org/oppia/android/util/networking/BUILD.bazel utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel utility/src/main/java/org/oppia/android/util/profile/BUILD.bazel utility/src/main/java/org/oppia/android/util/system/BUILD.bazel utility/src/main/java/org/oppia/android/util/threading/BUILD.bazel utility/src/test/java/org/oppia/android/util/caching/BUILD.bazel utility/src/test/java/org/oppia/android/util/caching/testing/BUILD.bazel utility/src/test/java/org/oppia/android/util/data/BUILD.bazel utility/src/test/java/org/oppia/android/util/locale/BUILD.bazel utility/src/test/java/org/oppia/android/util/locale/testing/BUILD.bazel utility/src/test/java/org/oppia/android/util/logging/BUILD.bazel utility/src/test/java/org/oppia/android/util/logging/firebase/BUILD.bazel utility/src/test/java/org/oppia/android/util/logging/performancemetrics/BUILD.bazel utility/src/test/java/org/oppia/android/util/networking/BUILD.bazel utility/src/test/java/org/oppia/android/util/profile/BUILD.bazel

Specifically: - The TODO check was fixed by reformatting a TODO comment. - The Proguard build was fixed by upgrading kotlinx.coroutines to use a version compatible with Kotlin 1.6, as well as adding a Proguard dontwarn directive for one class that can't execute on Android.

Conflicts: WORKSPACE config/proguard/kotlin-proguard-rules.pro third_party/BUILD.bazel third_party/maven_install.json third_party/versions.bzl

For some reason, the old kotlinx-coroutines-test was causing a codebase-wide incompatibility with the 1.6.x kotlinx-coroutines-core library, so this updates that version. It also updates Gradle dependencies for consistency, and to fix the Gradle builds. And, this fixes the IntelliJ Bazel plugin syncing issue when using kt_jvm_import (for kotlinx-coroutines-core-jvm).

…tlin1.6

This is to ensure Jetpack Compose compatibility.

Conflicts: third_party/maven_install.json

…l-and-kotlin Conflicts: third_party/maven_install.json

Aliases are cleaner and possibly more performant, but also more semantically correct than using wrapper libraries. Wrappers are now only used when actually needed (due to additional functionality or multiple targets being combined together).

…se-bazel-kt1.6 Conflicts: third_party/maven_install.json

…port' into feat/multiple-classrooms-ui-support Pull the model and domain related code

… into feat/multiple-classrooms-ui-support Fetch compose prototype on bazel

…port' into feat/multiple-classrooms-ui-support Merge controller changes

…port' into feat/multiple-classrooms-ui-support

…ewModel

…port' into feat/multiple-classrooms-ui-support

github-actions · 2024-06-21T04:24:33Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 18 MiB (new), 2536 KiB (Added)

APK download size (estimated): 14 MiB (old), 17 MiB (new), 2540 KiB (Added)

Method count: 222364 (old), 252688 (new), 30324 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6549 (new), 1 (Removed)

Anim: 49 (old), 43 (new), 6 (Removed):
- anim/fragment_close_enter (removed)
- anim/fragment_close_exit (removed)
- anim/fragment_fade_enter (removed)
- anim/fragment_fade_exit (removed)
- anim/fragment_open_enter (removed)
- And 1 other
Animator: 20 (old), 26 (new), 6 (Added):
- animator/fragment_close_enter (added)
- animator/fragment_close_exit (added)
- animator/fragment_fade_enter (added)
- animator/fragment_fade_exit (added)
- animator/fragment_open_enter (added)
- And 1 other
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 922 (new), 7 (Added):
- attr/actionModeCloseContentDescription (added)
- attr/actionModeTheme (added)
- attr/fontProviderSystemFontFamily (added)
- attr/lStar (added)
- attr/nestedScrollViewStyle (added)
- And 2 others
Bool: 10 (old), 9 (new), 1 (Removed):
- bool/abc_allow_stacked_button_bar (removed)
Color: 911 (old), 909 (new), 2 (Removed):
- color/color_palette_onboarding_primary_color (removed)
- color/color_palette_onboarding_primary_text_color (removed)
- color/component_color_onboarding_shared_green_color (removed)
- color/component_color_onboarding_shared_text_color (removed)
- color/component_color_onboarding_shared_white_color (removed)
- And 3 others
Dimen: 994 (old), 980 (new), 14 (Removed):
- dimen/clickable_item_min_width (removed)
- dimen/onboarding_profile_picture_padding (removed)
- dimen/onboarding_profile_picture_stroke_width (removed)
- dimen/onboarding_shared_corner_radius (removed)
- dimen/onboarding_shared_elevation (removed)
- And 23 others
Drawable: 373 (old), 366 (new), 7 (Removed):
- drawable/abc_ic_star_black_16dp (removed)
- drawable/abc_ic_star_black_36dp (removed)
- drawable/abc_ic_star_black_48dp (removed)
- drawable/abc_ic_star_half_black_16dp (removed)
- drawable/abc_ic_star_half_black_36dp (removed)
- And 18 others
Id: 1206 (old), 1216 (new), 10 (Added):
- id/onboarding_app_language_background (removed)
- id/onboarding_app_language_image (removed)
- id/onboarding_language_center_guide (removed)
- id/onboarding_language_dropdown_background (removed)
- id/onboarding_language_explanation (removed)
- And 31 others
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 367 (new), 1 (Removed):
- layout/activity_color_binding_adapters_test (removed)
- layout/color_binding_adapters_test_fragment (removed)
- layout/onboarding_app_language_selection_fragment (removed)
- layout/classroom_list_activity (added)
- layout/classroom_list_fragment (added)
Menu: 1 (old), 3 (new), 2 (Added):
- menu/example_menu (added)
- menu/example_menu2 (added)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 815 (new), 10 (Added):
- string/onboarding_language_activity_button_text (removed)
- string/onboarding_language_activity_explanation_text (removed)
- string/onboarding_language_activity_select_label (removed)
- string/onboarding_language_activity_subtitle (removed)
- string/onboarding_language_activity_text (removed)
- And 19 others
Style: 816 (old), 811 (new), 5 (Removed):
- style/OnboardingHeaderStyle (removed)
- style/OnboardingLanguageExplanationStyle (removed)
- style/OnboardingLanguageLabelStyle (removed)
- style/OnboardingLanguageLetsGoButton (removed)
- style/OnboardingLanguageMessageStyle (removed)
- And 2 others
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 18 MiB (new), 2593 KiB (Added)
APK download size (estimated): 14 MiB (old), 17 MiB (new), 2575 KiB (Added)
Method count: 222364 (old), 252688 (new), 30324 (Added)
Resources: 6486 (old), 6499 (new), 13 (Added)

Anim: 49 (old), 43 (new), 6 (Removed)
Animator: 20 (old), 26 (new), 6 (Added)
Attr: 915 (old), 922 (new), 7 (Added)
Bool: 9 (old), 8 (new), 1 (Removed)
Color: 911 (old), 909 (new), 2 (Removed)
Dimen: 990 (old), 976 (new), 14 (Removed)
Drawable: 314 (old), 321 (new), 7 (Added)
Id: 1206 (old), 1216 (new), 10 (Added)
Layout: 368 (old), 367 (new), 1 (Removed)
Menu: 1 (old), 3 (new), 2 (Added)
String: 805 (old), 815 (new), 10 (Added)
Style: 816 (old), 811 (new), 5 (Removed)

Configuration hdpi

APK file size: 59 KiB (old), 49 KiB (new), 10 KiB (Removed)
APK download size (estimated): 23 KiB (old), 18 KiB (new), 5649 bytes (Removed)
Resources: 68 (old), 54 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration ldpi

APK file size: 56 KiB (old), 48 KiB (new), 8868 bytes (Removed)
APK download size (estimated): 18 KiB (old), 14 KiB (new), 4120 bytes (Removed)
Resources: 67 (old), 53 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration mdpi

APK file size: 53 KiB (old), 45 KiB (new), 8832 bytes (Removed)
APK download size (estimated): 18 KiB (old), 14 KiB (new), 4214 bytes (Removed)
Resources: 67 (old), 53 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration tvdpi

APK file size: 102 KiB (old), 84 KiB (new), 18 KiB (Removed)
APK download size (estimated): 38 KiB (old), 29 KiB (new), 9506 bytes (Removed)
Resources: 68 (old), 54 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration xhdpi

APK file size: 67 KiB (old), 56 KiB (new), 11 KiB (Removed)
APK download size (estimated): 28 KiB (old), 21 KiB (new), 7018 bytes (Removed)
Resources: 68 (old), 54 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration xxhdpi

APK file size: 76 KiB (old), 62 KiB (new), 14 KiB (Removed)
APK download size (estimated): 38 KiB (old), 29 KiB (new), 8728 bytes (Removed)
Resources: 68 (old), 54 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Configuration xxxhdpi

APK file size: 79 KiB (old), 62 KiB (new), 16 KiB (Removed)
APK download size (estimated): 39 KiB (old), 28 KiB (new), 10 KiB (Removed)
Resources: 68 (old), 54 (new), 14 (Removed)

Drawable: 59 (old), 45 (new), 14 (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 852 KiB (Added)

APK download size (estimated): 9153 KiB (old), 9 MiB (new), 859 KiB (Added)

Method count: 99462 (old), 112334 (new), 12872 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5503 (new), 1 (Removed)

Anim: 39 (old), 33 (new), 6 (Removed):
- anim/fragment_close_enter (removed)
- anim/fragment_close_exit (removed)
- anim/fragment_fade_enter (removed)
- anim/fragment_fade_exit (removed)
- anim/fragment_open_enter (removed)
- And 1 other
Animator: 18 (old), 24 (new), 6 (Added):
- animator/fragment_close_enter (added)
- animator/fragment_close_exit (added)
- animator/fragment_fade_enter (added)
- animator/fragment_fade_exit (added)
- animator/fragment_open_enter (added)
- And 1 other
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 888 (new), 9 (Added):
- attr/actionModeCloseContentDescription (added)
- attr/actionModeTheme (added)
- attr/clockIcon (added)
- attr/fontProviderSystemFontFamily (added)
- attr/keyboardIcon (added)
- And 4 others
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 755 (new), 12 (Removed):
- color/color_def_black_25 (removed)
- color/color_palette_button_shadow_color (removed)
- color/color_palette_onboarding_primary_color (removed)
- color/color_palette_onboarding_primary_text_color (removed)
- color/color_palette_shared_black_background_color (removed)
- And 7 others
Dimen: 722 (old), 713 (new), 9 (Removed):
- dimen/clickable_item_min_width (removed)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (removed)
- dimen/mtrl_textinput_box_corner_radius_small (removed)
- dimen/onboarding_shared_corner_radius (removed)
- dimen/onboarding_shared_elevation (removed)
- And 24 others
Drawable: 333 (old), 328 (new), 5 (Removed):
- drawable/abc_ic_star_black_16dp (removed)
- drawable/abc_ic_star_black_36dp (removed)
- drawable/abc_ic_star_black_48dp (removed)
- drawable/abc_ic_star_half_black_16dp (removed)
- drawable/abc_ic_star_half_black_36dp (removed)
- And 20 others
Id: 1148 (old), 1162 (new), 14 (Added):
- id/onboarding_app_language_background (removed)
- id/onboarding_app_language_image (removed)
- id/onboarding_language_center_guide (removed)
- id/onboarding_language_dropdown_background (removed)
- id/onboarding_language_explanation (removed)
- And 35 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 330 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (removed)
- layout/color_binding_adapters_test_fragment (removed)
- layout/onboarding_app_language_selection_fragment (removed)
- layout/classroom_list_activity (added)
- layout/classroom_list_fragment (added)
- And 4 others
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 749 (new), 13 (Added):
- string/onboarding_language_activity_button_text (removed)
- string/onboarding_language_activity_explanation_text (removed)
- string/onboarding_language_activity_select_label (removed)
- string/onboarding_language_activity_subtitle (removed)
- string/onboarding_language_activity_text (removed)
- And 22 others
Style: 457 (old), 443 (new), 14 (Removed):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (removed)
- style/OnboardingHeaderStyle (removed)
- style/OnboardingLanguageExplanationStyle (removed)
- style/OnboardingLanguageLabelStyle (removed)
- style/OnboardingLanguageLetsGoButton (removed)
- And 11 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 10 MiB (new), 909 KiB (Added)
APK download size (estimated): 9034 KiB (old), 9 MiB (new), 895 KiB (Added)
Method count: 99462 (old), 112334 (new), 12872 (Added)
Resources: 5447 (old), 5460 (new), 13 (Added)

Anim: 39 (old), 33 (new), 6 (Removed)
Animator: 18 (old), 24 (new), 6 (Added)
Attr: 879 (old), 888 (new), 9 (Added)
Color: 767 (old), 755 (new), 12 (Removed)
Dimen: 720 (old), 711 (new), 9 (Removed)
Drawable: 279 (old), 288 (new), 9 (Added)
Id: 1148 (old), 1162 (new), 14 (Added)
Layout: 327 (old), 330 (new), 3 (Added)
String: 736 (old), 749 (new), 13 (Added)
Style: 457 (old), 443 (new), 14 (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 42 KiB (new), 10 KiB (Removed)
APK download size (estimated): 22 KiB (old), 17 KiB (new), 5726 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration ldpi

APK file size: 52 KiB (old), 43 KiB (new), 8900 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4225 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration mdpi

APK file size: 46 KiB (old), 37 KiB (new), 8828 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4245 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration tvdpi

APK file size: 90 KiB (old), 72 KiB (new), 18 KiB (Removed)
APK download size (estimated): 37 KiB (old), 27 KiB (new), 9612 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xhdpi

APK file size: 60 KiB (old), 49 KiB (new), 11 KiB (Removed)
APK download size (estimated): 27 KiB (old), 20 KiB (new), 7070 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxhdpi

APK file size: 69 KiB (old), 54 KiB (new), 14 KiB (Removed)
APK download size (estimated): 37 KiB (old), 28 KiB (new), 8697 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
APK download size (estimated): 38 KiB (old), 27 KiB (new), 10 KiB (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 10 MiB (new), 850 KiB (Added)

APK download size (estimated): 9140 KiB (old), 9 MiB (new), 858 KiB (Added)

Method count: 99462 (old), 112340 (new), 12878 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5503 (new), 1 (Removed)

Anim: 39 (old), 33 (new), 6 (Removed):
- anim/fragment_close_enter (removed)
- anim/fragment_close_exit (removed)
- anim/fragment_fade_enter (removed)
- anim/fragment_fade_exit (removed)
- anim/fragment_open_enter (removed)
- And 1 other
Animator: 18 (old), 24 (new), 6 (Added):
- animator/fragment_close_enter (added)
- animator/fragment_close_exit (added)
- animator/fragment_fade_enter (added)
- animator/fragment_fade_exit (added)
- animator/fragment_open_enter (added)
- And 1 other
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 888 (new), 9 (Added):
- attr/actionModeCloseContentDescription (added)
- attr/actionModeTheme (added)
- attr/clockIcon (added)
- attr/fontProviderSystemFontFamily (added)
- attr/keyboardIcon (added)
- And 4 others
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 755 (new), 12 (Removed):
- color/color_def_black_25 (removed)
- color/color_palette_button_shadow_color (removed)
- color/color_palette_onboarding_primary_color (removed)
- color/color_palette_onboarding_primary_text_color (removed)
- color/color_palette_shared_black_background_color (removed)
- And 7 others
Dimen: 722 (old), 713 (new), 9 (Removed):
- dimen/clickable_item_min_width (removed)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (removed)
- dimen/mtrl_textinput_box_corner_radius_small (removed)
- dimen/onboarding_shared_corner_radius (removed)
- dimen/onboarding_shared_elevation (removed)
- And 24 others
Drawable: 333 (old), 328 (new), 5 (Removed):
- drawable/abc_ic_star_black_16dp (removed)
- drawable/abc_ic_star_black_36dp (removed)
- drawable/abc_ic_star_black_48dp (removed)
- drawable/abc_ic_star_half_black_16dp (removed)
- drawable/abc_ic_star_half_black_36dp (removed)
- And 20 others
Id: 1148 (old), 1162 (new), 14 (Added):
- id/onboarding_app_language_background (removed)
- id/onboarding_app_language_image (removed)
- id/onboarding_language_center_guide (removed)
- id/onboarding_language_dropdown_background (removed)
- id/onboarding_language_explanation (removed)
- And 35 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 330 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (removed)
- layout/color_binding_adapters_test_fragment (removed)
- layout/onboarding_app_language_selection_fragment (removed)
- layout/classroom_list_activity (added)
- layout/classroom_list_fragment (added)
- And 4 others
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 749 (new), 13 (Added):
- string/onboarding_language_activity_button_text (removed)
- string/onboarding_language_activity_explanation_text (removed)
- string/onboarding_language_activity_select_label (removed)
- string/onboarding_language_activity_subtitle (removed)
- string/onboarding_language_activity_text (removed)
- And 22 others
Style: 457 (old), 443 (new), 14 (Removed):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (removed)
- style/OnboardingHeaderStyle (removed)
- style/OnboardingLanguageExplanationStyle (removed)
- style/OnboardingLanguageLabelStyle (removed)
- style/OnboardingLanguageLetsGoButton (removed)
- And 11 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 10 MiB (new), 907 KiB (Added)
APK download size (estimated): 9022 KiB (old), 9 MiB (new), 895 KiB (Added)
Method count: 99462 (old), 112340 (new), 12878 (Added)
Resources: 5447 (old), 5460 (new), 13 (Added)

Anim: 39 (old), 33 (new), 6 (Removed)
Animator: 18 (old), 24 (new), 6 (Added)
Attr: 879 (old), 888 (new), 9 (Added)
Color: 767 (old), 755 (new), 12 (Removed)
Dimen: 720 (old), 711 (new), 9 (Removed)
Drawable: 279 (old), 288 (new), 9 (Added)
Id: 1148 (old), 1162 (new), 14 (Added)
Layout: 327 (old), 330 (new), 3 (Added)
String: 736 (old), 749 (new), 13 (Added)
Style: 457 (old), 443 (new), 14 (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 42 KiB (new), 10 KiB (Removed)
APK download size (estimated): 22 KiB (old), 17 KiB (new), 5727 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration ldpi

APK file size: 52 KiB (old), 43 KiB (new), 8900 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4225 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration mdpi

APK file size: 46 KiB (old), 37 KiB (new), 8828 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4242 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration tvdpi

APK file size: 90 KiB (old), 72 KiB (new), 18 KiB (Removed)
APK download size (estimated): 37 KiB (old), 27 KiB (new), 9612 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xhdpi

APK file size: 60 KiB (old), 49 KiB (new), 11 KiB (Removed)
APK download size (estimated): 27 KiB (old), 20 KiB (new), 7069 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxhdpi

APK file size: 69 KiB (old), 54 KiB (new), 14 KiB (Removed)
APK download size (estimated): 37 KiB (old), 28 KiB (new), 8696 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
APK download size (estimated): 38 KiB (old), 27 KiB (new), 10 KiB (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 10 MiB (new), 850 KiB (Added)

APK download size (estimated): 9139 KiB (old), 9 MiB (new), 858 KiB (Added)

Method count: 99462 (old), 112340 (new), 12878 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5503 (new), 1 (Removed)

Anim: 39 (old), 33 (new), 6 (Removed):
- anim/fragment_close_enter (removed)
- anim/fragment_close_exit (removed)
- anim/fragment_fade_enter (removed)
- anim/fragment_fade_exit (removed)
- anim/fragment_open_enter (removed)
- And 1 other
Animator: 18 (old), 24 (new), 6 (Added):
- animator/fragment_close_enter (added)
- animator/fragment_close_exit (added)
- animator/fragment_fade_enter (added)
- animator/fragment_fade_exit (added)
- animator/fragment_open_enter (added)
- And 1 other
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 888 (new), 9 (Added):
- attr/actionModeCloseContentDescription (added)
- attr/actionModeTheme (added)
- attr/clockIcon (added)
- attr/fontProviderSystemFontFamily (added)
- attr/keyboardIcon (added)
- And 4 others
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 755 (new), 12 (Removed):
- color/color_def_black_25 (removed)
- color/color_palette_button_shadow_color (removed)
- color/color_palette_onboarding_primary_color (removed)
- color/color_palette_onboarding_primary_text_color (removed)
- color/color_palette_shared_black_background_color (removed)
- And 7 others
Dimen: 722 (old), 713 (new), 9 (Removed):
- dimen/clickable_item_min_width (removed)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (removed)
- dimen/mtrl_textinput_box_corner_radius_small (removed)
- dimen/onboarding_shared_corner_radius (removed)
- dimen/onboarding_shared_elevation (removed)
- And 24 others
Drawable: 333 (old), 328 (new), 5 (Removed):
- drawable/abc_ic_star_black_16dp (removed)
- drawable/abc_ic_star_black_36dp (removed)
- drawable/abc_ic_star_black_48dp (removed)
- drawable/abc_ic_star_half_black_16dp (removed)
- drawable/abc_ic_star_half_black_36dp (removed)
- And 20 others
Id: 1148 (old), 1162 (new), 14 (Added):
- id/onboarding_app_language_background (removed)
- id/onboarding_app_language_image (removed)
- id/onboarding_language_center_guide (removed)
- id/onboarding_language_dropdown_background (removed)
- id/onboarding_language_explanation (removed)
- And 35 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 330 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (removed)
- layout/color_binding_adapters_test_fragment (removed)
- layout/onboarding_app_language_selection_fragment (removed)
- layout/classroom_list_activity (added)
- layout/classroom_list_fragment (added)
- And 4 others
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 749 (new), 13 (Added):
- string/onboarding_language_activity_button_text (removed)
- string/onboarding_language_activity_explanation_text (removed)
- string/onboarding_language_activity_select_label (removed)
- string/onboarding_language_activity_subtitle (removed)
- string/onboarding_language_activity_text (removed)
- And 22 others
Style: 457 (old), 443 (new), 14 (Removed):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (removed)
- style/OnboardingHeaderStyle (removed)
- style/OnboardingLanguageExplanationStyle (removed)
- style/OnboardingLanguageLabelStyle (removed)
- style/OnboardingLanguageLetsGoButton (removed)
- And 11 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 10 MiB (new), 907 KiB (Added)
APK download size (estimated): 9022 KiB (old), 9 MiB (new), 894 KiB (Added)
Method count: 99462 (old), 112340 (new), 12878 (Added)
Resources: 5447 (old), 5460 (new), 13 (Added)

Anim: 39 (old), 33 (new), 6 (Removed)
Animator: 18 (old), 24 (new), 6 (Added)
Attr: 879 (old), 888 (new), 9 (Added)
Color: 767 (old), 755 (new), 12 (Removed)
Dimen: 720 (old), 711 (new), 9 (Removed)
Drawable: 279 (old), 288 (new), 9 (Added)
Id: 1148 (old), 1162 (new), 14 (Added)
Layout: 327 (old), 330 (new), 3 (Added)
String: 736 (old), 749 (new), 13 (Added)
Style: 457 (old), 443 (new), 14 (Removed)

Configuration hdpi

APK file size: 52 KiB (old), 42 KiB (new), 10 KiB (Removed)
APK download size (estimated): 22 KiB (old), 17 KiB (new), 5726 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration ldpi

APK file size: 52 KiB (old), 43 KiB (new), 8900 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4223 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration mdpi

APK file size: 46 KiB (old), 37 KiB (new), 8828 bytes (Removed)
APK download size (estimated): 17 KiB (old), 13 KiB (new), 4244 bytes (Removed)
Resources: 60 (old), 46 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration tvdpi

APK file size: 90 KiB (old), 72 KiB (new), 18 KiB (Removed)
APK download size (estimated): 37 KiB (old), 27 KiB (new), 9608 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xhdpi

APK file size: 60 KiB (old), 49 KiB (new), 11 KiB (Removed)
APK download size (estimated): 27 KiB (old), 20 KiB (new), 7070 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxhdpi

APK file size: 69 KiB (old), 54 KiB (new), 14 KiB (Removed)
APK download size (estimated): 37 KiB (old), 28 KiB (new), 8698 bytes (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
APK download size (estimated): 38 KiB (old), 27 KiB (new), 10 KiB (Removed)
Resources: 61 (old), 47 (new), 14 (Removed)

Drawable: 54 (old), 40 (new), 14 (Removed)

BenHenning added 30 commits March 29, 2023 17:09

Fix Dagger structure.

b2ca68b

This moves the codebase to using the recommended single top-level Dagger library rather than replicating it in a bunch of different places.

Upgrade Dagger version.

839be0f

This is needed for downstream work. It also includes ensuring that Guava JRE can never be used (since only Android should ever be referenced by the production app build).

Fix test builds that depend on Dagger generation.

c2fe337

Update Maven dependency licenses.

a543500

Fix broken test & binary builds.

b882832

Add support for Kotlin 1.6.

c5b940b

There's some cleanup work needed beyond this, but this is the core change to introduce Kotlin 1.6 support (at least for dev builds). Moshi needed to be upgraded due to a metadata incompatibility when moving over to Kotlin 1.6.

Correctly interact with rules_kotlin.

10ae796

rules_kotlin moved its imports into more structured bzl files to load, so this updates all references in the codebase to point to the correct locations (which removes debug warnings that show up on the CLI).

Turn on warnings as errors for Kotlin.

d2799f0

Fixed all warnings that the compiler warned about. Removed ViewModelProvider & fixed state leaking entirely by moving away from Jetpack's ViewModel as a base class (since we aren't correctly using that correctly).

Fix static check failures.

6f9bbd6

Post-merge fixes.

a4790a4

Fix Proguard builds (temp) and static failures.

b74ecbb

Merge branch 'develop' into upgrade-compute-affected-tests

aaa0299

Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

d520fa9

…xternal

Merge branch 'update-rules-jvm-external' into update-dagger-structure

037be61

Merge branch 'update-dagger-structure' into upgrade-to-kotlin1.6

756534a

Fix CI breakages, including Gradle.

a92e37c

Merge branch 'upgrade-to-kotlin1.6' into add-build-stats-ci-workflow

bb8592b

Conflicts: build.gradle data/build.gradle domain/build.gradle third_party/maven_install.json

Post-merge dep fixes + test fix.

9890877

Undo unnecessary changes.

f118fa2

Post-merge fixes.

151ecca

Merge branch 'upgrade-to-kotlin1.6' into add-build-stats-ci-workflow

6b5291f

Conflicts: WORKSPACE config/proguard/kotlin-proguard-rules.pro third_party/BUILD.bazel third_party/maven_install.json third_party/versions.bzl

Post-merge fixes.

125be3c

Address self-review comments.

59f7f87

BenHenning and others added 26 commits May 26, 2024 20:57

Merge branch 'fix-build-time-kotlin-java-warnings' into upgrade-to-ko…

eda781e

…tlin1.6

Down version to 1.6.10.

82c530a

This is to ensure Jetpack Compose compatibility.

Merge branch 'upgrade-to-kotlin1.6' into add-build-stats-ci-workflow

05bc1c2

Conflicts: third_party/maven_install.json

Merge branch 'add-build-stats-ci-workflow' into migrate-to-newer-baze…

386a487

…l-and-kotlin Conflicts: third_party/maven_install.json

Update third-party wrappers to use aliases.

62795b1

Aliases are cleaner and possibly more performant, but also more semantically correct than using wrapper libraries. Wrappers are now only used when actually needed (due to additional functionality or multiple targets being combined together).

Merge branch 'migrate-to-newer-bazel-and-kotlin' into prototype-compo…

62acdf8

…se-bazel-kt1.6 Conflicts: third_party/maven_install.json

Merge remote-tracking branch 'upstream/multiple-classrooms-domain-sup…

517bf53

…port' into feat/multiple-classrooms-ui-support Pull the model and domain related code

Merge remote-tracking branch 'upstream/prototype-compose-bazel-kt1.6'…

1018102

… into feat/multiple-classrooms-ui-support Fetch compose prototype on bazel

Add jetpack compose dependencies on Gradle

497d307

Merge remote-tracking branch 'upstream/multiple-classrooms-domain-sup…

13bcd00

…port' into feat/multiple-classrooms-ui-support Merge controller changes

Merge remote-tracking branch 'upstream/multiple-classrooms-domain-sup…

7ebeb47

…port' into feat/multiple-classrooms-ui-support

Create ClassroomListActivity, ClassroomListFragment & ClassroomListVi…

4ca4ff6

…ewModel

Gate the new ClassroomListActivity

75b748c

Add welcome component UI

a0df38f

Merge remote-tracking branch 'upstream/multiple-classrooms-domain-sup…

af1c1f4

…port' into feat/multiple-classrooms-ui-support

Add classroom list component UI

f763b81

Merge remote-tracking branch 'upstream/multiple-classrooms-domain-sup…

02c96cc

…port' into feat/multiple-classrooms-ui-support

Add promoted story list component UI

a12729d

Add topic list component UI

f1a931a

Update padding values and hide classroom icons in landscape

1a20a8a

Move the components to separate files

6395915

Fix versions.bzl syntax error

37fb32a

Remove topic_list_to_cache

8cba9da

Make card bg transparent

f0f800c

Make promoted story and topic cards clickable

c1a3ce8

Define card bg colours

8cfcf7e

theMr17 changed the base branch from develop to multiple-classrooms-domain-support June 17, 2024 16:16

Temporary topic list data flow changes

16e3e96

theMr17 closed this Jun 21, 2024

Prototype Multiple Classrooms UI #5424

Prototype Multiple Classrooms UI #5424

Conversation

theMr17 commented Jun 17, 2024

Explanation

Essential Checklist

For UI-specific PRs only

github-actions bot commented Jun 21, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi