Fix Part of #4938: Introduce New App Language Selection Screen for onboarding #5373

adhiamboperes · 2024-03-27T19:20:39Z

Explanation

Fixes Part of #4938: Introuduces new app language selection screen.

This PR introduces the layout files and the presenter for displaying the language functionality, along with associated test cases.

I have modified the custom view SurveyOnboardingBackgroundView to make it generic and reusable in the new layouts.

These changes include both darkmode support and alternate screen size and orientation layouts, as per figma mocks.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only


	Lightmode Portrait	Darkmode & Landscape
Mobile xxhdpi
Mobile mdpi
Tablet xxhdpi
Tablet hdpi

theMr17

Thanks @adhiamboperes! I have left some comments. PTAL.

app/src/main/res/drawable/dropdown_background.xml

app/src/main/java/org/oppia/android/app/customview/OppiaCurveBackgroundView.kt

app/src/main/java/org/oppia/android/app/onboardingv2/OnboardingFragmentPresenter.kt

scripts/assets/kdoc_validity_exemptions.textproto

app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt

app/src/main/res/values/component_colors.xml

oppiabot · 2024-03-31T15:53:20Z

Unassigning @theMr17 since the review is done.

oppiabot · 2024-03-31T15:53:23Z

Hi @adhiamboperes, it looks like some changes were requested on this pull request by @theMr17. PTAL. Thanks!

…oarding-screen

adhiamboperes · 2024-04-03T15:38:20Z

@theMr17, I have addressed your comments, PTAL.

oppiabot · 2024-04-03T15:41:24Z

Unassigning @adhiamboperes since a re-review was requested. @adhiamboperes, please make sure you have addressed all review comments. Thanks!

theMr17

Thanks @adhiamboperes! This LGTM.

oppiabot · 2024-04-04T10:54:46Z

Unassigning @theMr17 since they have already approved the PR.

…creen # Conflicts: # app/src/sharedTest/java/org/oppia/android/app/databinding/BUILD.bazel

adhiamboperes · 2024-06-03T17:53:52Z

@BenHenning, I have addressed all your comments. PTAL.

oppiabot · 2024-06-10T18:44:24Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

…creen # Conflicts: # app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt

github-actions · 2024-06-13T04:05:39Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 17 MiB (new), 1151 KiB (Added)

APK download size (estimated): 14 MiB (old), 16 MiB (new), 1134 KiB (Added)

Method count: 214503 (old), 235368 (new), 20865 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6492 (old), 6550 (new), 58 (Added)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 906 (old), 911 (new), 5 (Added):
- color/color_palette_onboarding_primary_color (added)
- color/color_palette_onboarding_primary_text_color (added)
- color/component_color_onboarding_shared_green_color (added)
- color/component_color_onboarding_shared_text_color (added)
- color/component_color_onboarding_shared_white_color (added)
Dimen: 973 (old), 994 (new), 21 (Added):
- dimen/clickable_item_min_width (added)
- dimen/onboarding_profile_picture_padding (added)
- dimen/onboarding_profile_picture_stroke_width (added)
- dimen/onboarding_shared_corner_radius (added)
- dimen/onboarding_shared_elevation (added)
- And 16 others
Drawable: 370 (old), 373 (new), 3 (Added):
- drawable/dropdown_background (added)
- drawable/ic_language_icon_black_24dp (added)
- drawable/otter (added)
Id: 1193 (old), 1206 (new), 13 (Added):
- id/onboarding_app_language_background (added)
- id/onboarding_app_language_image (added)
- id/onboarding_language_center_guide (added)
- id/onboarding_language_dropdown_background (added)
- id/onboarding_language_explanation (added)
- And 8 others
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 365 (old), 368 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (added)
- layout/color_binding_adapters_test_fragment (added)
- layout/onboarding_app_language_selection_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 798 (old), 805 (new), 7 (Added):
- string/onboarding_language_activity_button_text (added)
- string/onboarding_language_activity_explanation_text (added)
- string/onboarding_language_activity_select_label (added)
- string/onboarding_language_activity_subtitle (added)
- string/onboarding_language_activity_text (added)
- And 2 others
Style: 810 (old), 816 (new), 6 (Added):
- style/OnboardingHeaderStyle (added)
- style/OnboardingLanguageExplanationStyle (added)
- style/OnboardingLanguageLabelStyle (added)
- style/OnboardingLanguageLetsGoButton (added)
- style/OnboardingLanguageMessageStyle (added)
- And 1 other
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 17 MiB (new), 1150 KiB (Added)
APK download size (estimated): 14 MiB (old), 15 MiB (new), 1138 KiB (Added)
Method count: 214503 (old), 235368 (new), 20865 (Added)
Resources: 6427 (old), 6485 (new), 58 (Added)

Color: 906 (old), 911 (new), 5 (Added)
Dimen: 968 (old), 989 (new), 21 (Added)
Drawable: 311 (old), 314 (new), 3 (Added)
Id: 1193 (old), 1206 (new), 13 (Added)
Layout: 365 (old), 368 (new), 3 (Added)
String: 798 (old), 805 (new), 7 (Added)
Style: 810 (old), 816 (new), 6 (Added)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 280 bytes (Added)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 3 bytes (Added)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 352 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 3 bytes (Added)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 288 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 103 KiB (new), 488 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 344 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Added)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 288 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 4 bytes (Added)

Configuration xxxhdpi

APK file size: 78 KiB (old), 79 KiB (new), 296 bytes (Added)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 1 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 33 KiB (Added)

APK download size (estimated): 9016 KiB (old), 9044 KiB (new), 28 KiB (Added)

Method count: 93710 (old), 93608 (new), 102 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5432 (old), 5504 (new), 72 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 755 (old), 767 (new), 12 (Added):
- color/color_def_black_25 (added)
- color/color_palette_button_shadow_color (added)
- color/color_palette_onboarding_primary_color (added)
- color/color_palette_onboarding_primary_text_color (added)
- color/color_palette_shared_black_background_color (added)
- And 7 others
Dimen: 703 (old), 722 (new), 19 (Added):
- dimen/clickable_item_min_width (added)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (added)
- dimen/mtrl_textinput_box_corner_radius_small (added)
- dimen/onboarding_shared_corner_radius (added)
- dimen/onboarding_shared_elevation (added)
- And 14 others
Drawable: 330 (old), 333 (new), 3 (Added):
- drawable/ic_language_icon_black_24dp (added)
- drawable/otter (added)
- drawable/rounded_primary_button_grey_shadow_color (added)
Id: 1135 (old), 1148 (new), 13 (Added):
- id/onboarding_app_language_background (added)
- id/onboarding_app_language_image (added)
- id/onboarding_language_center_guide (added)
- id/onboarding_language_dropdown_background (added)
- id/onboarding_language_explanation (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 324 (old), 327 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (added)
- layout/color_binding_adapters_test_fragment (added)
- layout/onboarding_app_language_selection_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 729 (old), 736 (new), 7 (Added):
- string/onboarding_language_activity_button_text (added)
- string/onboarding_language_activity_explanation_text (added)
- string/onboarding_language_activity_select_label (added)
- string/onboarding_language_activity_subtitle (added)
- string/onboarding_language_activity_text (added)
- And 2 others
Style: 442 (old), 457 (new), 15 (Added):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (added)
- style/OnboardingHeaderStyle (added)
- style/OnboardingLanguageExplanationStyle (added)
- style/OnboardingLanguageLabelStyle (added)
- style/OnboardingLanguageLetsGoButton (added)
- And 10 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 32 KiB (Added)
APK download size (estimated): 8897 KiB (old), 8930 KiB (new), 32 KiB (Added)
Method count: 93710 (old), 93608 (new), 102 (Removed)
Resources: 5374 (old), 5446 (new), 72 (Added)

Color: 755 (old), 767 (new), 12 (Added)
Dimen: 700 (old), 719 (new), 19 (Added)
Drawable: 276 (old), 279 (new), 3 (Added)
Id: 1135 (old), 1148 (new), 13 (Added)
Layout: 324 (old), 327 (new), 3 (Added)
String: 729 (old), 736 (new), 7 (Added)
Style: 442 (old), 457 (new), 15 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 204 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 14 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 336 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 8 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 208 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 340 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 4 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 268 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 68 KiB (old), 69 KiB (new), 208 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 212 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 9 bytes (Added)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 32 KiB (Added)

APK download size (estimated): 9003 KiB (old), 9032 KiB (new), 29 KiB (Added)

Method count: 93710 (old), 93608 (new), 102 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5432 (old), 5504 (new), 72 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 755 (old), 767 (new), 12 (Added):
- color/color_def_black_25 (added)
- color/color_palette_button_shadow_color (added)
- color/color_palette_onboarding_primary_color (added)
- color/color_palette_onboarding_primary_text_color (added)
- color/color_palette_shared_black_background_color (added)
- And 7 others
Dimen: 703 (old), 722 (new), 19 (Added):
- dimen/clickable_item_min_width (added)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (added)
- dimen/mtrl_textinput_box_corner_radius_small (added)
- dimen/onboarding_shared_corner_radius (added)
- dimen/onboarding_shared_elevation (added)
- And 14 others
Drawable: 330 (old), 333 (new), 3 (Added):
- drawable/ic_language_icon_black_24dp (added)
- drawable/otter (added)
- drawable/rounded_primary_button_grey_shadow_color (added)
Id: 1135 (old), 1148 (new), 13 (Added):
- id/onboarding_app_language_background (added)
- id/onboarding_app_language_image (added)
- id/onboarding_language_center_guide (added)
- id/onboarding_language_dropdown_background (added)
- id/onboarding_language_explanation (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 324 (old), 327 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (added)
- layout/color_binding_adapters_test_fragment (added)
- layout/onboarding_app_language_selection_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 729 (old), 736 (new), 7 (Added):
- string/onboarding_language_activity_button_text (added)
- string/onboarding_language_activity_explanation_text (added)
- string/onboarding_language_activity_select_label (added)
- string/onboarding_language_activity_subtitle (added)
- string/onboarding_language_activity_text (added)
- And 2 others
Style: 442 (old), 457 (new), 15 (Added):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (added)
- style/OnboardingHeaderStyle (added)
- style/OnboardingLanguageExplanationStyle (added)
- style/OnboardingLanguageLabelStyle (added)
- style/OnboardingLanguageLetsGoButton (added)
- And 10 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 32 KiB (Added)
APK download size (estimated): 8887 KiB (old), 8915 KiB (new), 28 KiB (Added)
Method count: 93710 (old), 93608 (new), 102 (Removed)
Resources: 5374 (old), 5446 (new), 72 (Added)

Color: 755 (old), 767 (new), 12 (Added)
Dimen: 700 (old), 719 (new), 19 (Added)
Drawable: 276 (old), 279 (new), 3 (Added)
Id: 1135 (old), 1148 (new), 13 (Added)
Layout: 324 (old), 327 (new), 3 (Added)
String: 729 (old), 736 (new), 7 (Added)
Style: 442 (old), 457 (new), 15 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 204 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 16 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 336 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 7 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 208 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 340 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 4 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 268 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 68 KiB (old), 69 KiB (new), 208 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 2 bytes (Added)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 212 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 8 bytes (Added)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 32 KiB (Added)

APK download size (estimated): 9003 KiB (old), 9032 KiB (new), 29 KiB (Added)

Method count: 93710 (old), 93608 (new), 102 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5432 (old), 5504 (new), 72 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 755 (old), 767 (new), 12 (Added):
- color/color_def_black_25 (added)
- color/color_palette_button_shadow_color (added)
- color/color_palette_onboarding_primary_color (added)
- color/color_palette_onboarding_primary_text_color (added)
- color/color_palette_shared_black_background_color (added)
- And 7 others
Dimen: 703 (old), 722 (new), 19 (Added):
- dimen/clickable_item_min_width (added)
- dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset (added)
- dimen/mtrl_textinput_box_corner_radius_small (added)
- dimen/onboarding_shared_corner_radius (added)
- dimen/onboarding_shared_elevation (added)
- And 14 others
Drawable: 330 (old), 333 (new), 3 (Added):
- drawable/ic_language_icon_black_24dp (added)
- drawable/otter (added)
- drawable/rounded_primary_button_grey_shadow_color (added)
Id: 1135 (old), 1148 (new), 13 (Added):
- id/onboarding_app_language_background (added)
- id/onboarding_app_language_image (added)
- id/onboarding_language_center_guide (added)
- id/onboarding_language_dropdown_background (added)
- id/onboarding_language_explanation (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 324 (old), 327 (new), 3 (Added):
- layout/activity_color_binding_adapters_test (added)
- layout/color_binding_adapters_test_fragment (added)
- layout/onboarding_app_language_selection_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 729 (old), 736 (new), 7 (Added):
- string/onboarding_language_activity_button_text (added)
- string/onboarding_language_activity_explanation_text (added)
- string/onboarding_language_activity_select_label (added)
- string/onboarding_language_activity_subtitle (added)
- string/onboarding_language_activity_text (added)
- And 2 others
Style: 442 (old), 457 (new), 15 (Added):
- style/Base.Widget.MaterialComponents.AutoCompleteTextView (added)
- style/OnboardingHeaderStyle (added)
- style/OnboardingLanguageExplanationStyle (added)
- style/OnboardingLanguageLabelStyle (added)
- style/OnboardingLanguageLetsGoButton (added)
- And 10 others
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 32 KiB (Added)
APK download size (estimated): 8887 KiB (old), 8915 KiB (new), 28 KiB (Added)
Method count: 93710 (old), 93608 (new), 102 (Removed)
Resources: 5374 (old), 5446 (new), 72 (Added)

Color: 755 (old), 767 (new), 12 (Added)
Dimen: 700 (old), 719 (new), 19 (Added)
Drawable: 276 (old), 279 (new), 3 (Added)
Id: 1135 (old), 1148 (new), 13 (Added)
Layout: 324 (old), 327 (new), 3 (Added)
String: 729 (old), 736 (new), 7 (Added)
Style: 442 (old), 457 (new), 15 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 204 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 16 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 336 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 9 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 208 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 340 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 8 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 268 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 68 KiB (old), 69 KiB (new), 208 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 212 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 8 bytes (Added)

BenHenning

Thanks @adhiamboperes! PR LGTM. Feel free to resolve the last few comments when they seem addressed & merge at your convenience.

app/src/sharedTest/java/org/oppia/android/app/databinding/ColorBindingAdaptersTest.kt

app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragment.kt

app/src/main/res/layout-sw600dp-land/onboarding_app_language_selection_fragment.xml

…oarding-screen

adhiamboperes · 2024-06-18T20:58:44Z

Enabling Auto-merge, everything looks good after addressing remaining comments.

adhiamboperes added 5 commits March 27, 2024 16:36

Add drawable resources

5d86f13

Make SurveyOnboardingBackgroundView generic for reuse.

a17713d

Create app language selection UI

7c11bcd

Add tests for the new app language screen

722c759

Fix UI

0a24f11

adhiamboperes requested review from a team as code owners March 27, 2024 19:20

adhiamboperes requested a review from BenHenning March 27, 2024 19:20

adhiamboperes self-assigned this Mar 27, 2024

Fix buildifier issue

1462eb7

adhiamboperes assigned theMr17 and unassigned adhiamboperes Mar 27, 2024

theMr17 requested changes Mar 31, 2024

View reviewed changes

oppiabot bot unassigned theMr17 Mar 31, 2024

oppiabot bot assigned adhiamboperes Mar 31, 2024

adhiamboperes added 4 commits April 3, 2024 14:46

Addressed general feedback

5fb890e

Fix curve background for landscape orientation

adbdbed

Flatten Bg drawable

4f0c57b

Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…

187726c

…oarding-screen

oppiabot bot assigned theMr17 and unassigned adhiamboperes Apr 3, 2024

theMr17 approved these changes Apr 4, 2024

View reviewed changes

oppiabot bot unassigned theMr17 Apr 4, 2024

adhiamboperes added 10 commits June 2, 2024 13:49

Fix failing tests and set up bazel test

7c69c15

Merge remote-tracking branch 'upstream/develop' into new-onboarding-s…

0a7c600

…creen # Conflicts: # app/src/sharedTest/java/org/oppia/android/app/databinding/BUILD.bazel

Fix ktlint

1c0494f

Replace otter png with SVG

a8c207a

Fix failing tests and general cleanup

1172ff6

Fix test file exemption

4612e6b

Fix accessibility label exemption

d3451ab

Fix drawable vector hex exemption

6095c54

Fix unused exemption

2540989

Fix failing test

65d9f11

adhiamboperes assigned BenHenning and unassigned adhiamboperes Jun 3, 2024

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 10, 2024

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 11, 2024

adhiamboperes added 2 commits June 11, 2024 16:57

Merge remote-tracking branch 'upstream/develop' into new-onboarding-s…

f14bbb1

…creen # Conflicts: # app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt

Fix merge conflict

3fdf74f

BenHenning approved these changes Jun 14, 2024

View reviewed changes

BenHenning assigned adhiamboperes and unassigned BenHenning Jun 14, 2024

adhiamboperes added 4 commits June 17, 2024 15:44

Merge branch 'develop' into new-onboarding-screen

72624f5

Address reviewer comments

9b29b36

Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…

7d72412

…oarding-screen

Fix adapter namespace

275a287

adhiamboperes enabled auto-merge (squash) June 18, 2024 20:58

adhiamboperes merged commit 8e5cb49 into develop Jun 18, 2024
41 checks passed

adhiamboperes deleted the new-onboarding-screen branch June 18, 2024 21:26

Fix Part of #4938: Introduce New App Language Selection Screen for onboarding #5373

Fix Part of #4938: Introduce New App Language Selection Screen for onboarding #5373

Conversation

adhiamboperes commented Mar 27, 2024 • edited Loading

Explanation

Essential Checklist

For UI-specific PRs only

theMr17 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 31, 2024

oppiabot bot commented Mar 31, 2024

adhiamboperes commented Apr 3, 2024

oppiabot bot commented Apr 3, 2024

theMr17 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Apr 4, 2024

adhiamboperes commented Jun 3, 2024

oppiabot bot commented Jun 10, 2024

github-actions bot commented Jun 13, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

BenHenning left a comment

Choose a reason for hiding this comment

adhiamboperes commented Jun 18, 2024

adhiamboperes commented Mar 27, 2024 •

edited

Loading