Fix #3258 - Handling Removal of the CircularImageView dependency

[Rd4dev]

Explanation

Fixes #3258

The Pull Request #4155 substituted CircularImageView with ShapeableImageView, yet the dependency persists in the project. This PR addresses the final steps of removing the remaining dependency.

add_shadow and shadow_radius were exclusive to CircularImageView. Upon removing the dependencies, these attributes became irrelevant, so they were omitted from the layouts. Their removal had no impact on the functioning views as they were unrelated to the actual attributes of the working views.
[Attached reference images below]

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Todo

Remove Dependency from Bazel and External libraries.!

[Rd4dev]

@adhiamboperes PTAL

[adhiamboperes]

Thanks @Rd4dev!

Isn't there a declaration of this in third_party/versions.bzl?

[Rd4dev]

Hi @adhiamboperes,

The third_party/versions.bzl file appears to be missing the CircularImageView dependency.
It seems that PR #2659 might have overlooked the addition of com.jackandphantom.android:circularimageview.

Two dependencies were initially employed for circular images:

• de.hdodenhof:circleimageview:3.0.1
  added initally via PR Fixes part of #16 and #44: Implementation of ProfileChooserFragment #326

• com.jackandphantom.android:circularimageview:1.2.0
  added initially via PR Fix #949: User Profile hifi #959
  Also to note: this dependency does exist in the third_party/versions.bzl file

Both dependencies were eventually mixed in layouts, with de.hdodenhof.circleimageview.CircleImageView predominantly
[ref. PR #4155].

Issue #3258 mentions replacing com.jackandphantom.android:circularimageview, but the comment suggests replacing de.hdodenhof.circleimageview.CircleImageView as well which was implemented in PR #4155.

Seeking clarification on whether it is appropriate to proceed with the removal of de.hdodenhof.circleimageview.CircleImageView, given that none of the layouts appear to utilize this dependency.

[adhiamboperes]

@Rd4dev , please remove the dependency as it is unused.

[Rd4dev]

@adhiamboperes PTAL

[oppiabot]

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

Thanks @Rd4dev, this looks good, but please resolve the merge conflict and then reassign to me.

[Rd4dev]

@adhiamboperes PTAL

[oppiabot]

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

Thanks @Rd4dev!

[oppiabot]

Unassigning @adhiamboperes since they have already approved the PR.

[oppiabot]

Assigning @BenHenning for code owner reviews. Thanks!

[BenHenning]

This is a really nice clean-up, thanks for doing this @Rd4dev! LGTM.

[BenHenning]

Updating with latest & enabling auto-merge since everything seems to look good.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!